Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 Mar 2018 10:32:19 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Josh Paetzel <josh@tcbug.org>
Cc:        Mathieu Arnold <mat@FreeBSD.org>, Ash Gokhale <ashfixit@gmail.com>, Diane Bruce <db@db.net>, Kurt Jaeger <lists@opsec.eu>, Kurt Jaeger <pi@opsec.eu>, freebsd-ports@freebsd.org
Subject:   Re: net/viamillipede seeks commiter
Message-ID:  <20180307093219.wk552zxzfiuwocnv@atuin.in.mat.cc>
In-Reply-To: <1520373004.824022.1293952168.17AFDF2D@webmail.messagingengine.com>
References:  <20180303080634.GC32429@home.opsec.eu> <CAHpe%2B0awr0zL9Tp0=CKt3nLK4BQdKFEGk3qwPvjkboeeogPONA@mail.gmail.com> <B271493C-591B-4FDC-98A3-3B11CB2262BD@tcbug.org> <CAHpe%2B0a8vNKYxhT=p6OOUgbKtpFqEdmjSrsP_tFo3J5Sx9PUdg@mail.gmail.com> <20180303185149.GD32429@home.opsec.eu> <1520182718.1126475.1291006864.4F744B98@webmail.messagingengine.com> <CAHpe%2B0ZzP3BBDHTBMnLRoOtF4YreSh=FfF0vCarVa9VANtz0BQ@mail.gmail.com> <CAHpe%2B0a9cgKuGmX=0jEtcUbz81LcZVt3kdsVekDo4A7aFzGJ4Q@mail.gmail.com> <20180306161922.b3b62oxibu6s4pit@ogg.in.absolight.net> <1520373004.824022.1293952168.17AFDF2D@webmail.messagingengine.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--c4hgr7t266dhf2im
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 06, 2018 at 09:50:04PM +0000, Josh Paetzel wrote:
>=20
>=20
> On Tue, Mar 6, 2018, at 10:19 AM, Mathieu Arnold wrote:
> > On Tue, Mar 06, 2018 at 07:34:39AM -0500, Ash Gokhale wrote:
> > > gcc.  Would you  all try it again please?
> > > https://github.com/agokhale/freebsd-port-net-viamillipede/commits/mas=
ter
> > >=20
> >=20
> > Add to the top block DISTVERSIONPREFIX=3Dv and change the version to 0.=
7.
> >=20
> > Remove MASTER_SITES.
> >=20
> > Remove GH_TAGNAME=3D v0.7
> >=20
> > BINS seems to not be used, remove it.
> >=20
> > pkg-descr needs a big cleanup.
> >=20
> > --=20
> > Mathieu Arnold
> > Email had 1 attachment:
> > + signature.asc
> >   1k (application/pgp-signature)
>=20
> It looks like all the changes suggested have been done,  both poudriere a=
nd portlint are happy.
>=20
> If there are no objections I'll commit this tonight.

The bad_ideas target at the end of the Makefile needs to go before this
is committed.

There still is a superfluous space at the start of a line in pkg-descr.

The pkg-plist file should probably be removed in favor of using
PLIST_FILES in the Makefile.

There is a file containing the license in the software's git repository,
so using LICENSE_FILE would probably be a good idea too.

The file named LICENSE in that repository must not be committed.

--=20
Mathieu Arnold

--c4hgr7t266dhf2im
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQJ8BAABCgBmBQJan7GjXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IfpQP/0h+77VBqkGEcPK21ax3txwH
4FBAj9Vct+fEhV5h8uMZ7VsLZST77LQXROaICxFf8Qy3ez59drnmIeiR07ph1BT6
W0K64qnmOVVsj4cHVAI1iS1fX9GqYeyJn9jDW1N1/x/IKwgHKVIXAzxRIORKMlYx
t6FNKMMg5a6v2oT/9dFgk70L3K0dMu54eOrkzJnFMe4FaDelsB97+aP5fnfzI5zN
MAILRV/0VMRB56DzTLhsKXZCsrEq2H67UtZ1WieR4GWuB2kD88eC57evVcLhjDeR
WkEYm0Y3bASh5cM7x2VZGGlzYcWZUgu/5oh2ciBWRZail7pdWWfMQnFwcgnKaw88
Mf74/S38kCrlBBALXRhl85UKB6W6Sp546Se6D9WTXpG0QDJTTbR3uKdC7+2jhWU3
uAMosm2rwhmxErtwo5X3r1cEFgiSoci5dhN1/TAshLx5nlGYHhElVvI/jPlS/m+9
sgHRY5J3irUwH3SWNhonent6CxVakFH5zpycrh/cE3l6i4AoWOVaaURquZCu2A7O
MSAl00e+gogDPgxQrhv6SHKEfzNSYzxrAROjwu6lMwxvLpkvTLxFvPU76Wb2zZbG
YYmOrR+xuQy312Md3GV4VF6kdoB0v7lnZCorCqhMhItPPy4iIyRXGw8n3RiW+wWA
aAfNFVsls6ZCdaL1ibhC
=86pN
-----END PGP SIGNATURE-----

--c4hgr7t266dhf2im--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180307093219.wk552zxzfiuwocnv>