From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Oct 27 00:58:24 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 53D5B16A4CE; Wed, 27 Oct 2004 00:58:24 +0000 (GMT)
Received: from mailsat.dstm.de (mailsat.dstm.de [62.8.207.209])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D1BFA43D1F; Wed, 27 Oct 2004 00:58:23 +0000 (GMT)
	(envelope-from wak@mailsat.dstm.de)
Received: from [10.7.4.5] (tweety.dstm.de [10.7.4.5])
	by mailsat005.dstm.de (Postfix) with ESMTP id 9C57D85C;
	Wed, 27 Oct 2004 02:57:53 +0200 (CEST)
Message-ID: <417EF2AE.7080806@mailsat.dstm.de>
Date: Wed, 27 Oct 2004 02:58:22 +0200
From: "Wolfram A. Kraushaar" <wak@mailsat.dstm.de>
User-Agent: Mozilla Thunderbird 0.8 (X11/20041026)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: oliver@freebsd.org, freebsd-ports-bugs@FreeBSD.org
Content-Type: multipart/mixed;
 boundary="------------040200070300050600030200"
Subject: ports/xfce4-fm: patch for tubo.c on 5.3 Stable
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Oct 2004 00:58:24 -0000

This is a multi-part message in MIME format.
--------------040200070300050600030200
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

it seems the FreeBSD patch (included in the xfce sources)
for tubo.c breaks xfsamba functionality in the same way
it has resolved before in earlier versions of FreeBSD.
(sorry for this weird english ;-))

Bug of earlier FreeBSD versions described at:
http://bugzilla.xfce.org/show_bug.cgi?id=57
(zombie/100% processor load at nmblookup -M -- -)

removing the "#ifdef __FreeBSD__" part of tubo.c fixed the
issue on my FreeBSD 5.3 STABLE box with samba 3.0.7 and
xfce-fm-4.0.6

attached is a patch to revert the changes for FreeBSD 5.3
Stable.

--
Wolfram

--------------040200070300050600030200
Content-Type: text/plain;
 name="patch-tubo.c"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="patch-tubo.c"

*** libs/tubo.c.orig	Mon Dec 29 21:43:25 2003
--- libs/tubo.c	Wed Oct 27 02:24:00 2004
***************
*** 300,308 ****
      fork_struct *forkO;
      int status;
      forkO = (fork_struct *) ((long)fork_object);
- #ifdef	__FreeBSD__
-     if (kill(forkO->childPID,SIGCONT) == 0) return TRUE;
- #endif
      waitpid(forkO->childPID, &status, WNOHANG);
      if(WIFEXITED(status) || WIFSIGNALED(status))
      {
--- 300,305 ----

--------------040200070300050600030200--