From owner-svn-src-all@freebsd.org Mon Aug 31 01:33:49 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A66153D2117; Mon, 31 Aug 2020 01:33:49 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bft5S5G9Gz3byD; Mon, 31 Aug 2020 01:33:48 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f41.google.com with SMTP id b16so4351986ioj.4; Sun, 30 Aug 2020 18:33:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w5nwVzZ/aF2JtDBxx1K0tmsWwWH8+kLQgoGv+vhGdnk=; b=aVYk5SMNiblelu6BM4wH4u8HhnlZAn1xlYs0XoLi4B9ueEm5+eHIbTF3MDu3am9mMf ixubYDoq+fU1/nW9a5T9qYNzjfL8WXgknoqZF4fBM+lCnFVHJ+lYqFFEvzD5/N5nPFSd CmsaT24d4j8hNfa9HaynqyCboz1UI5PcA1ZhedFLgzsHTy+2Jo7wUsKw9niNpAGxDJ8I S/ABhxbiOxvP1ricnige/DQOcWkuwFG1NfFwZSgyyUmSo0Fm80ltHp6pQSOo3TVj79ad ex4UPVCXgktwoKKvG5xdrph61Looqvav5+0CGdCS2FbPMB3rfUVrRvQBE9PSElzX8cP1 rf0Q== X-Gm-Message-State: AOAM533Q72KnM34sAj7cX8VIBOMp9RRebtEvYotTyKAYnvdnyGrBdQor ksL/z7HSVATpfWCXQzaK56NI6eMNLH02ribBLmGQo2EnvyQ= X-Google-Smtp-Source: ABdhPJxGbYg9meU2/i627J5AkjD6RvJTp6RuRxuoOWc4x2wNz7a/J+xgxFPlojbC3mKZWEjgj/fQyPWxF/sn5kdxta0= X-Received: by 2002:a05:6638:2595:: with SMTP id s21mr9730358jat.12.1598837626012; Sun, 30 Aug 2020 18:33:46 -0700 (PDT) MIME-Version: 1.0 References: <202008171853.07HIrNAC082123@repo.freebsd.org> <202008172023.07HKNh1q061925@gndrsh.dnsmgr.net> In-Reply-To: <202008172023.07HKNh1q061925@gndrsh.dnsmgr.net> From: Ed Maste Date: Sun, 30 Aug 2020 21:33:31 -0400 Message-ID: Subject: Re: svn commit: r364321 - head/sbin/ipfw To: "Rodney W. Grimes" Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4Bft5S5G9Gz3byD X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.41 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-1.14 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[carpeddiem]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-0.83)[-0.834]; NEURAL_SPAM_SHORT(0.41)[0.411]; NEURAL_HAM_MEDIUM(-0.71)[-0.714]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.166.41:from]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.166.41:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2020 01:33:49 -0000 Hrm, it seems this reply ended up in my spam folder; sorry for not replying until now. > > *strchr(timestr, '\n') = '\0'; > > bprintf(bp, "%s ", timestr); > ^ Isnt this the +1 space? > > > } else { > > - bprintf(bp, "%*s", twidth, " "); > > + bprintf(bp, "%*s", twidth + 1, " "); > ^missing from this string? Inserting an extra space in the format string would also work, sure. I considered doing it that way but in the end decided it's not materially more clear one way or another, so used the patch as submitted.