Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Jul 2022 18:47:50 GMT
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: d0917822a28b - stable/13 - Fix unused variable warning in xen's blkfront.c
Message-ID:  <202207291847.26TIlouJ024631@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by dim:

URL: https://cgit.FreeBSD.org/src/commit/?id=d0917822a28b2f49a40d5145993c5870d8a056ca

commit d0917822a28b2f49a40d5145993c5870d8a056ca
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2022-07-26 12:01:26 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-07-29 18:32:08 +0000

    Fix unused variable warning in xen's blkfront.c
    
    With clang 15, the following -Werror warning is produced:
    
        sys/dev/xen/blkfront/blkfront.c:602:6: error: variable 'sbp' set but not used [-Werror,-Wunused-but-set-variable]
                int sbp;
                    ^
    
    The 'sbp' variable was used in the for loop later in the xb_dump()
    function, but refactoring in e4808c4b2dba got rid of it. Remove the
    variable since it no longer serves any purpose.
    
    MFC after:      3 days
    
    (cherry picked from commit e635220e1a330560ee547069054d81c4cf0b7839)
---
 sys/dev/xen/blkfront/blkfront.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sys/dev/xen/blkfront/blkfront.c b/sys/dev/xen/blkfront/blkfront.c
index 6292dbaf7a1b..88f4f82b4bce 100644
--- a/sys/dev/xen/blkfront/blkfront.c
+++ b/sys/dev/xen/blkfront/blkfront.c
@@ -600,7 +600,6 @@ xbd_dump(void *arg, void *virtual, off_t offset, size_t length)
 	struct xbd_softc *sc = dp->d_drv1;
 	struct xbd_command *cm;
 	size_t chunk;
-	int sbp;
 	int rc = 0;
 
 	if (length == 0)
@@ -615,7 +614,7 @@ xbd_dump(void *arg, void *virtual, off_t offset, size_t length)
 	mtx_lock(&sc->xbd_io_lock);
 
 	/* Split the 64KB block as needed */
-	for (sbp=0; length > 0; sbp++) {
+	while (length > 0) {
 		cm = xbd_dequeue_cm(sc, XBD_Q_FREE);
 		if (cm == NULL) {
 			mtx_unlock(&sc->xbd_io_lock);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202207291847.26TIlouJ024631>