From owner-cvs-src@FreeBSD.ORG Wed Feb 1 18:56:54 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4DD5516A420; Wed, 1 Feb 2006 18:56:54 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id A469643D46; Wed, 1 Feb 2006 18:56:53 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id k11ItO1P056892; Wed, 1 Feb 2006 11:55:24 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 01 Feb 2006 11:55:24 -0700 (MST) Message-Id: <20060201.115524.104088017.imp@bsdimp.com> To: bakul@BitBlocks.com From: Warner Losh In-Reply-To: <200602011851.k11Ip8VO071628@gate.bitblocks.com> References: <20060201183036.GA30206@xor.obsecurity.org> <200602011851.k11Ip8VO071628@gate.bitblocks.com> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 01 Feb 2006 11:55:25 -0700 (MST) Cc: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, stefanf@freebsd.org, ru@freebsd.org, sgk@troutmask.apl.washington.edu, kris@obsecurity.org, stefan@fafoe.narf.at Subject: Re: cvs commit: src/sys/sys cdefs.h src/include nl_types.h stdio.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2006 18:56:54 -0000 From: Bakul Shah Subject: Re: cvs commit: src/sys/sys cdefs.h src/include nl_types.h stdio.h Date: Wed, 01 Feb 2006 10:51:08 -0800 > > On Wed, Feb 01, 2006 at 10:25:28AM -0800, Bakul Shah wrote: > > > > I'm actually surprised that make includes doesn't install the sys > > > > directory as well, which would pick up the new sys/cdefs.h. Does > > > > 'make -f Makefile.inc _includes' also exhibit the same problem? > > >=20 > > > The bigger question is *why* does buildworld depend on > > > /usr/include. > > > > You have to compile native bootstrap tools (i.e. against /usr/include) > > before you can build the rest of the world with "internal" headers. > > If you don't do this bootstrap step, your buildworld won't work in all > > upgrade cases. > > But look at this error message Steve Kargl posted: > > ===> games/fortune/strfile (obj,depend,all,install) > cc -O2 -fno-strict-aliasing -pipe -I/usr/obj/usr/src/tmp/legacy/usr/include -c > /usr/src/games/fortune/strfile/strfile.c > In file included from /usr/src/games/fortune/strfile/strfile.c:53: > /usr/include/stdio.h:331: error: syntax error before "__format_arg" > > Is /usr/games/fortune is a build tool? Even if /usr/includes > is not consistent due to make includes, surely fortune > shouldn't care since it includes only the "internal" headers? > Internal meaning the ones in the target system. > > BTW, I have seen similar things in the past few weeks while > doing buildworld and the only way to fix this was to do make > includes. > > Anyway, if it is only build tools that rely on host includes, > why do you need make includes at all? If you do, that says > that the build tools are relying on new stuff that they are > supposed to help build and install. > > More generally don't the build tools need to have an even > more stable environment? The problem is that Steve Kargl had an pooched /usr/include. He updated part of it, but not all of it, evidence suggests. In that cross threaded environment, mismatches between different parts of the tree can be bad. strfile is a build tool. It is used to build fortune and must be built using the host's build environment. Warner