Date: Mon, 02 Mar 2009 12:10:36 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Oliver Lehmann <lehmann@ans-netz.de> Cc: ports@freebsd.org, stable@freebsd.org, dan@langille.org Subject: Re: restart a script in etc/rc.d Message-ID: <49AC3D3C.8040106@FreeBSD.org> In-Reply-To: <20090302202520.eaf09b15.lehmann@ans-netz.de> References: <20090302163843.cc66c55e.lehmann@ans-netz.de> <alpine.BSF.2.00.0903021100190.59723@qbhto.arg> <20090302202520.eaf09b15.lehmann@ans-netz.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Oliver Lehmann wrote:
> Hi Doug,
>
> Doug Barton wrote:
>
>> Also, the assignment of pidfile should really come after the defaults are
>> set.
>>
>> If you do all that and it still doesn't work, send a diff of your two rc.d
>> scripts to the list.
>
> PROVIDE is in both cases "utility" (probably a generic unchanged default)
> - I've changed it to utility2 for bacula-fd2 with no changes. Here the diff:
That's arguably a bug. It should be something more descriptive. The
standard is that the name of the script file, the $name variable and
the PROVIDE line should all match.
> root@nudel rc.d> diff -u bacula-fd*
> --- bacula-fd 2009-02-15 23:25:03.000000000 +0100
> +++ bacula-fd2 2009-03-02 20:22:40.000000000 +0100
> @@ -16,16 +16,16 @@
>
> . /etc/rc.subr
>
> -name="bacula_fd"
> +name="bacula_fd2"
> rcvar=${name}_enable
> command=/usr/local/sbin/bacula-fd
>
> load_rc_config $name
>
> -pidfile="${bacula_fd_pidfile}"
> +pidfile="${bacula_fd2_pidfile}"
You missed the bit where I said that this should come after the
assignment of the defaults below.
> -: ${bacula_fd_enable="NO"}
> -: ${bacula_fd_flags=" -u root -g wheel -v -c /usr/local/etc/bacula-fd.conf"}
> -: ${bacula_fd_pidfile="/var/run/bacula-fd.9102.pid"}
> +: ${bacula_fd2_enable="NO"}
> +: ${bacula_fd2_flags=" -u root -g wheel -v -c /usr/local/etc/bacula-fd2.conf"}
> +: ${bacula_fd2_pidfile="/var/run/bacula-fd.9104.pid"}
>
> run_rc_command "$1"
> Exit 1
> root@nudel rc.d> grep bacula_fd /etc/rc.conf
> bacula_fd_enable="YES"
> bacula_fd2_enable="YES"
> bacula_fd2_flags=" -u root -g wheel -v -c /usr/local/etc/bacula-fd2.conf"
> bacula_fd2_pidfile="/var/run/bacula-fd.9104.pid"
Have you confirmed that the two pid files exist, and that they contain
the right information?
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49AC3D3C.8040106>