From owner-svn-src-all@FreeBSD.ORG Fri Jul 15 14:45:35 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E547C106566B; Fri, 15 Jul 2011 14:45:35 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107]) by mx1.freebsd.org (Postfix) with ESMTP id 862968FC19; Fri, 15 Jul 2011 14:45:35 +0000 (UTC) Received: from turtle.stack.nl (turtle.stack.nl [IPv6:2001:610:1108:5010::132]) by mx1.stack.nl (Postfix) with ESMTP id 55FDF1DD758; Fri, 15 Jul 2011 16:45:34 +0200 (CEST) Received: by turtle.stack.nl (Postfix, from userid 1677) id 48BFF17467; Fri, 15 Jul 2011 16:45:34 +0200 (CEST) Date: Fri, 15 Jul 2011 16:45:34 +0200 From: Jilles Tjoelker To: Kevin Lo Message-ID: <20110715144534.GA78212@stack.nl> References: <201107150159.p6F1x9rG055220@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201107150159.p6F1x9rG055220@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r224048 - head/etc/rc.d X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2011 14:45:36 -0000 On Fri, Jul 15, 2011 at 01:59:09AM +0000, Kevin Lo wrote: > Author: kevlo > Date: Fri Jul 15 01:59:08 2011 > New Revision: 224048 > URL: http://svn.freebsd.org/changeset/base/224048 > Log: > Remove "-n" from echo > Reviewed by: dougb > Modified: > head/etc/rc.d/routing > Modified: head/etc/rc.d/routing > ============================================================================== > --- head/etc/rc.d/routing Fri Jul 15 01:50:40 2011 (r224047) > +++ head/etc/rc.d/routing Fri Jul 15 01:59:08 2011 (r224048) > @@ -287,7 +287,7 @@ options_inet() > > if checkyesno gateway_enable; then > ropts_init > - echo -n ' IPv4 gateway=YES' > + echo ' IPv4 gateway=YES' > ${SYSCTL} net.inet.ip.forwarding=1 > /dev/null > else > ${SYSCTL} net.inet.ip.forwarding=0 > /dev/null > @@ -322,7 +322,7 @@ options_inet6() > { > if checkyesno ipv6_gateway_enable; then > ropts_init > - echo -n ' IPv6 gateway=YES' > + echo ' IPv6 gateway=YES' > ${SYSCTL} net.inet6.ip6.forwarding=1 > /dev/null > else > ${SYSCTL} net.inet6.ip6.forwarding=0 > /dev/null It looks like this has been added because some IPv6 code is printing stuff about routes for ::ffff:0.0.0.0, ::0.0.0.0, fe80:: and ff02::, which often gets in between things on the "Additional routing options:" line, leading to ugly output. However, it is inconsistent to change this for the gateway options only and not for the other options and makes output uglier unnecessarily in the !IPv6 case. Perhaps it is best to use a separate line for each af, finishing it within the options_$af function. -- Jilles Tjoelker