From owner-freebsd-net@FreeBSD.ORG Tue Aug 18 22:51:20 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5CF5C106568B; Tue, 18 Aug 2009 22:51:20 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id 5DAE18FC64; Tue, 18 Aug 2009 22:51:18 +0000 (UTC) Received: from tarsier.geekcn.org (tarsier.geekcn.org [211.166.10.233]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id 6894A5C06F; Wed, 19 Aug 2009 06:51:16 +0800 (CST) Received: from localhost (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id 2DC8A55CDC93; Wed, 19 Aug 2009 06:51:16 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by localhost (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with ESMTP id OsXNu-VMTdCN; Wed, 19 Aug 2009 06:50:22 +0800 (CST) Received: from charlie.delphij.net (adsl-76-237-33-62.dsl.pltn13.sbcglobal.net [76.237.33.62]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 6202855CDC88; Wed, 19 Aug 2009 06:50:11 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=AUEOSaaD+NfOGzbHy3noZ2kFRcNnofy1xJclK+BShPaX/7bgg6gy/AS7hlwb2SvKk V802FhXSCsO8S0okOJ8mA== Message-ID: <4A8B3011.6070104@delphij.net> Date: Tue, 18 Aug 2009 15:49:53 -0700 From: Xin LI Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.22 (X11/20090803) MIME-Version: 1.0 To: Barney Cordoba References: <527700.21341.qm@web63902.mail.re1.yahoo.com> In-Reply-To: <527700.21341.qm@web63902.mail.re1.yahoo.com> X-Enigmail-Version: 0.96.0 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: pyunyh@gmail.com, David Christensen , "d@delphij.net" , Julian Elischer , "freebsd-net@freebsd.org" , Jack Vogel , Jack F Vogel , yongari@freebsd.org Subject: Re: [PATCH] Fix for e1000 (em/igb) NOARP issue [Was Re: em(4): sending ARP regardless of NOARP flag] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2009 22:51:20 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Barney Cordoba wrote: > > --- On Tue, 8/18/09, Pyun YongHyeon wrote: > >> From: Pyun YongHyeon >> Subject: Re: [PATCH] Fix for e1000 (em/igb) NOARP issue [Was Re: em(4): sending ARP regardless of NOARP flag] >> To: "Xin LI" >> Cc: "Barney Cordoba" , "David Christensen" , "d@delphij..net" , "freebsd-net@freebsd.org" , "Jack Vogel" , "Jack F Vogel" , yongari@freebsd.org, "Julian Elischer" >> Date: Tuesday, August 18, 2009, 5:49 PM >> On Tue, Aug 18, 2009 at 02:03:37PM >> -0700, Xin LI wrote: >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA1 >>> >>> Hi, Jack, >>> >>> I have looked into the code history and found that >> sys/dev/em/if_em.c,v >>> 1.119 has introduced the arp_ifinit() call in order to >> fix the problem >>> that if_em won't send ARP when IP address is changed. >>> >>> I think we can further improve it as attached, say, >> only do it when >>> IFF_NOARP is not set. This should have no effect >> for usual >>> configuration but fix the problem when NOARP is the >> desired behavior. >> That change was introduced by me. I guess the root cause of >> the >> problem was long initialization time of hardware which in >> turn >> resulted in unbearable boot time when multiple-alias >> addresses are >> assigned to em(4). I don't remember details,though. >> >> Since we're in the release cycle, the change you suggested >> would be >> quick fix for 8.0. I think em(4)/igb(4) should remove >> SIOCSIFADDR >> handling in driver which is layering violation. > > There are 2 kinds of programmers; those who do things "correctly', > and those that do things that work. > > 99.99999% of the people will be using ARPs, so don't be silly and > break the driver to solve a case that almost no-one cares about please. I see no reason how you have reached the "99.99999%" conclusion. My employer for instance, has several millions of dollars worth of hardware purchase every year, and, we do care about DSR, or NOARP being working or not. Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (FreeBSD) iEYEARECAAYFAkqLMBEACgkQi+vbBBjt66DtJACcCuMIEljhYtKT/B9xP18HYzLD gMwAmwQpJiVSzFJzgXoNggWdRF/kj2Qs =ROT8 -----END PGP SIGNATURE-----