From owner-freebsd-current@FreeBSD.ORG  Wed Jun 16 05:19:52 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 98FC616A502
	for <current@FreeBSD.org>; Wed, 16 Jun 2004 05:19:52 +0000 (GMT)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 416B743D5E
	for <current@FreeBSD.org>; Wed, 16 Jun 2004 05:19:52 +0000 (GMT)
	(envelope-from nate@root.org)
Received: (qmail 30837 invoked by uid 1000); 16 Jun 2004 05:19:18 -0000
Date: Tue, 15 Jun 2004 22:19:18 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: John Baldwin <jhb@FreeBSD.org>
In-Reply-To: <200406152015.30925.jhb@FreeBSD.org>
Message-ID: <20040615221850.G30834@root.org>
References: <20040614165455.W22842@root.org>
	<200406152015.30925.jhb@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: current@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/acpica acpi.c acpi_acad.c acpi_button.c
 acpi_resource.c acpivar.h
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jun 2004 05:19:53 -0000

On Tue, 15 Jun 2004, John Baldwin wrote:
> On Monday 14 June 2004 07:57 pm, Nate Lawson wrote:
> > I think I know my problem.  I was testing using modules and so I had the
> > latest changes to acpi.ko (which now don't init the table to NULL) but no
> > changes to the kernel (checking for the acpi devclass).
> >
> > Sorry, this looks like pilot error.  I'll test the change of just using
> > devclass_find() instead of also device_get_softc() and commit.
>
> devclass_find() will succeed even if acpi0 fails to probe.  The softc is only
> null if the device is attached I suppose, so even if you do
> devclass_get_device() you have to check to see if the device_t's state is >
> DS_NOTPRESENT.  device_get_softc() manages to do that for you in one check
> since a DS_NOTPRESENT device has a NULL softc (as does a non-existent
> device).

Ack!  Please back out my commit.  Dealing with a hard drive crash here so
can't commit right now.

-Nate