From owner-freebsd-bugs@FreeBSD.ORG Mon Jan 28 22:50:00 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id DFA10DD4 for ; Mon, 28 Jan 2013 22:50:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id AE8241F4 for ; Mon, 28 Jan 2013 22:50:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r0SMo0k3064699 for ; Mon, 28 Jan 2013 22:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r0SMo0bt064698; Mon, 28 Jan 2013 22:50:00 GMT (envelope-from gnats) Resent-Date: Mon, 28 Jan 2013 22:50:00 GMT Resent-Message-Id: <201301282250.r0SMo0bt064698@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Yuri Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id AB398CA1 for ; Mon, 28 Jan 2013 22:40:05 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 9C428193 for ; Mon, 28 Jan 2013 22:40:05 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r0SMe5rY064451 for ; Mon, 28 Jan 2013 22:40:05 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id r0SMe5bh064450; Mon, 28 Jan 2013 22:40:05 GMT (envelope-from nobody) Message-Id: <201301282240.r0SMe5bh064450@red.freebsd.org> Date: Mon, 28 Jan 2013 22:40:05 GMT From: Yuri To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: misc/175661: [PATCH] Fix in libdtrace/Makefile of the dependency on dt_grammar.h X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2013 22:50:00 -0000 >Number: 175661 >Category: misc >Synopsis: [PATCH] Fix in libdtrace/Makefile of the dependency on dt_grammar.h >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jan 28 22:50:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Yuri >Release: 9.1-STABLE >Organization: n/a >Environment: >Description: Currently standalone build of libdtrace (cd /usr/src/cddl/lib/libdtrace && make clean && make) fails because dt_grammar.h is missing. It is consumed by few modules, like dt_cc.c, listed before dt_grammar.y that is producing it. I am not sure why overall build doesn't fail for this reason, but if someone just needs to rebuild libdtrace.so he will see this failure. This patch adds missing dependencies into the Makefile. The weaker patch fixing the same problem would have been just moving dt_grammar.y into the first position in list in Makefile. But make will still have wrong dependency list and it will likely break on parallel build (-j 8). >How-To-Repeat: >Fix: Patch attached with submission follows: Index: cddl/lib/libdtrace/Makefile =================================================================== --- cddl/lib/libdtrace/Makefile (revision 246040) +++ cddl/lib/libdtrace/Makefile (working copy) @@ -86,6 +86,13 @@ CLEANFILES= dt_errtags.c dt_names.c +dt_grammar.h: dt_grammar.y +dt_lex.o: dt_grammar.h +dt_xlator.o: dt_grammar.h +dt_cc.o: dt_grammar.h +dt_cg.o: dt_grammar.h +dt_parser.o: dt_grammar.h + dt_errtags.c: sh ${OPENSOLARIS_USR_DISTDIR}/lib/libdtrace/common/mkerrtags.sh < ${OPENSOLARIS_USR_DISTDIR}/lib/libdtrace/common/dt_errtags.h > dt_errtags.c >Release-Note: >Audit-Trail: >Unformatted: