From owner-freebsd-emulation@FreeBSD.ORG  Wed Jun 10 21:22:17 2015
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: vbox@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org
 [IPv6:2001:1900:2254:206a::19:2])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 01EBE27D
 for <vbox@freebsd.org>; Wed, 10 Jun 2015 21:22:17 +0000 (UTC)
 (envelope-from jkim@FreeBSD.org)
Received: from hammer.pct.niksun.com (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx2.freebsd.org (Postfix) with ESMTP id B4E2D3006;
 Wed, 10 Jun 2015 21:22:16 +0000 (UTC)
 (envelope-from jkim@FreeBSD.org)
Message-ID: <5578AA88.6040200@FreeBSD.org>
Date: Wed, 10 Jun 2015 17:22:16 -0400
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Mateusz Guzik <mjguzik@gmail.com>, vbox@freebsd.org
Subject: Re: virtualbox kmod build fix after r284215
References: <20150610194853.GF23380@dft-labs.eu>
In-Reply-To: <20150610194853.GF23380@dft-labs.eu>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-Mailman-Approved-At: Thu, 11 Jun 2015 00:07:02 +0000
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Development of Emulators of other operating systems
 <freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-emulation>, 
 <mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation/>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
 <mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jun 2015 21:22:17 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 06/10/2015 15:48, Mateusz Guzik wrote:
> Hello,
> 
> the following is needed since r284215 (__FreeBSD_version 1100077):
> 
> --- ./src/VBox/Runtime/r0drv/freebsd/memobj-r0drv-freebsd.c.orig 
> 2015-06-10 19:30:28.355276494 +0000 +++ 
> ./src/VBox/Runtime/r0drv/freebsd/memobj-r0drv-freebsd.c	2015-06-10
>  19:30:41.280304985 +0000 @@ -747,7 +747,7 @@ { /** @todo: is this
>  needed?. */ PROC_LOCK(pProc); -        AddrR3 = 
> round_page((vm_offset_t)pProc->p_vmspace->vm_daddr + lim_max(pProc,
> RLIMIT_DATA)); +        AddrR3 = 
> round_page((vm_offset_t)pProc->p_vmspace->vm_daddr + 
> lim_max_proc(pProc, RLIMIT_DATA)); PROC_UNLOCK(pProc); } else

Committed (r389147), thanks!

> Interestingly enough for some reason the build does not fail 
> without the patch, even though resulting code is clearly broken as
>  lim_max now expects a thread argument.

Yes, kernel module build is very fragile ATM and it should be fixed.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVeKqIAAoJEHyflib82/FG6RMH/i6o37JDe+CY/m3K9GOaL9LM
e6Rn65pMarZUeU3TvNchtqaK2SZF2gGo2b0CPnrRddE6Ufomm5molazoGcs9nSJX
MqCHs0bisg4zyo37JOHOWPQ5go/J6hfO1pPCGBhQ8E3j2BpyeRJykebnOwUQ9Tei
G7mTV78l0joEjkrxXt55TYuARtTuY8ISlyfzyXibghVm1meNvz0/CLcadgUkgn1a
H42XSsBpaJpSLrv8MW7+7rm8snc/Z3zWwd8vGHjRcUfQbyvPCMhMuLntMyW+t2yx
Eij4QYe+h2yfIXPW1M3h8amOCkMT8hJlQEfC9ZcroPjtIdanwv+6DuNWOfBLQMM=
=twB8
-----END PGP SIGNATURE-----