From nobody Thu Apr 9 16:35:30 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fs5C675Smz6YC7v for ; Thu, 09 Apr 2026 16:35:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fs5C65Ttbz4HQ9 for ; Thu, 09 Apr 2026 16:35:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775752530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=j1KWE9o2lkcKZQT8JY6aN/DDNvJZmc7OrCvB332+bvg=; b=QRRwgvFdHDqaijTeu3Bp/XO4UZLvtQQm211oiOpIHrkStH7q4tc65jTypD8XkHnjMj9I8/ mUbynluHGmeNsxvug+JBnJYWDS3PhCtWKI5KZl9PQxJelatTSPUkR5qMS48+YKqnmQqUgK czKaEDIXFqkkauMSjyWNA9r5V/zk38+2EQFInx9KqJZk2ksNidePZywdYdwEhqlIq53ePr q5iqiNNpsuImEdEyfQZeYhAOLfh5htES7lZzCTQXeQqc+6+S54F6Zrjp6E1B/+iJMpt9Uq wIgaLE10/twey5n9SCeF7wZB/RwtuWvvG/rdYnBdXs4MddbK8pEo3iF4Bp71lQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1775752530; a=rsa-sha256; cv=none; b=ZjLEQADASeBZjDSJOiNuETVllhgHQXd3Q75zsUCV1KiGcJxb5nRFj1wlCJ9g+oVU4EK24q Yq6h0SrwYdnC0m9Skbf39oLF3YHCCbGi11ogBpg87fQNqdGcz1yUxFdGojKxd2C7963bWb ++kQlMM9maMnHELHvQne6ytmQSHiM3R2MXeXmCFXotvRDZG+CAGYl0tbLa+ZI0QU7evPVa behAU/OpX27vrSIKM8XBZLFYPhdYdXLQlLM5qoiiwxzuhfcAcrhNJjts+4U364830x7wvQ oFGNB18b7vU1vrlDsJ1YuSoBThsAh32LnbvIQHmoM4hqwIdnHSATE6iz9JwLmg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775752530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=j1KWE9o2lkcKZQT8JY6aN/DDNvJZmc7OrCvB332+bvg=; b=wNNva4lQv7lVv0/kBl9A8dWmZtAoKV+yTw0z1WAlfh4GIxOW3bTJfe2Wf2EGT3p0q3t9pn EYk/twNV7l7DGHEwwy83CPr7BybDkG3Ac1gHj+5+C4JeJDlnzVz15DWo3GmqdTi821Z/ph CFs9zAvm3VyN6ttMQfgIZh4M31GEfuClnaRYyzkBqCVo2ANNmqbNDHvt64twzid6J0kwSg 69AA/Wv9DoCDyr00gPVpKNJHEJ0GvgSZlohJCdMjrgS3/JeOZOHe+X+0hFZNYl3rykCYF6 1atFBfnleTRqzO59S1D8+lL4TkPWpQGgkQthWrHmG8iupt6hinJ0G2YIe5OEkQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fs5C64zm1z1KtC for ; Thu, 09 Apr 2026 16:35:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24a3c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 09 Apr 2026 16:35:30 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Ali Mashtizadeh From: Mitchell Horne Subject: git: f86ba3eec596 - main - hwpmc: prevent IBS fetch from getting stuck List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f86ba3eec5961c0217b5458663e0eae5bbad314e Auto-Submitted: auto-generated Date: Thu, 09 Apr 2026 16:35:30 +0000 Message-Id: <69d7d552.24a3c.9850f95@gitrepo.freebsd.org> The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=f86ba3eec5961c0217b5458663e0eae5bbad314e commit f86ba3eec5961c0217b5458663e0eae5bbad314e Author: Ali Mashtizadeh AuthorDate: 2026-04-07 23:33:03 +0000 Commit: Mitchell Horne CommitDate: 2026-04-09 16:35:26 +0000 hwpmc: prevent IBS fetch from getting stuck Both fetch and op IBS sampling have the same problem where we need to rewrite the control MSR to ensure sampling continues at the correct rate. I also like this because it resets the counter reducing the chances that we collect a sample inside the NMI handler. Reported by: Aalok Agarwal Reviewed by: mhorne Sponsored by: Netflix Fixes: e51ef8ae490f ("hwpmc: Initial support for AMD IBS") Pull Request: https://github.com/freebsd/freebsd-src/pull/2130 --- sys/dev/hwpmc/hwpmc_ibs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/hwpmc/hwpmc_ibs.c b/sys/dev/hwpmc/hwpmc_ibs.c index ec1afcb47666..a230288f157e 100644 --- a/sys/dev/hwpmc/hwpmc_ibs.c +++ b/sys/dev/hwpmc/hwpmc_ibs.c @@ -342,6 +342,8 @@ pmc_ibs_process_fetch(struct pmc *pm, struct trapframe *tf, uint64_t config) } pmc_process_interrupt_mp(PMC_HR, pm, tf, &mpd); + + wrmsr(IBS_FETCH_CTL, pm->pm_md.pm_ibs.ibs_ctl | IBS_FETCH_CTL_ENABLE); } static void