From nobody Wed Sep 10 21:23:18 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cMYZr0B4Fz66tGB for ; Wed, 10 Sep 2025 21:23:32 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cMYZq5BP6z47jV for ; Wed, 10 Sep 2025 21:23:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-32b4c6a2a98so13136a91.1 for ; Wed, 10 Sep 2025 14:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1757539409; x=1758144209; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UrZcnr9PmTyERGhVX75xxRf8JjbWvhaPLiuhZQfpKN8=; b=hUvXXI9n94iuhiGeuJ7WyMumEh2cXbLApG0LWt1q7ypLxtfNSE6ZK9rqChn+u7lq7+ uSsmA/7yhWPw83yY58d6NUzreQgoSqkcL73FOa2GBiytmNGKpsL0Jtbe9OK/dOdQeShl rh1i2AUHy8CK9ZPLt0+tub8MSlGui7XiQOQKTYrpU48zBvWj63fcdadLmR93E0Kf7cV7 r+H4/zCrzO2KMKr+znm8HW6B9jgJRWG0btl3iOdFHk7ifhzjzJFzEyoOwr20cv5yYJpI Kjsc8qrwomZER69o47CEib+TqSIKkoC6L1j60KbNhxFiYIoDk5XHUA9LG+3ERFRATrOj uGFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757539409; x=1758144209; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UrZcnr9PmTyERGhVX75xxRf8JjbWvhaPLiuhZQfpKN8=; b=KwI37yhmOPNelij1uyp/DO4rsp6dS4SrsmySoR4+wnf7FdF/FcQkMUKcZrxYOveXXK LdEOLRqMDy9nVqjtLT8Ucpcxd0fyyO0JOYCuJBqgwLnIhmY01aELAJc60n41UJaM38Ez +hcskfCABK9tLbkCNTVQJUB1htKxM+JyiC3bJ6hr9w/wMqV90GiE0F5LgfJnZGV/I8vL 9bN4dZZUsfio2dc6TaSZezTYhhNlR+pCBYJEeGl+FIfIXlYXvumlpImjnyKKEK8VgGZ+ p4dKD+I/S2L1v0o4/hn9wOVjXH42A7c+4ngMgmXuNP22mvvu6HTynShYKfrA0amBafx5 icaA== X-Forwarded-Encrypted: i=1; AJvYcCXNem+vnu4GUMxHm0J1OZoXf1z+ycnTE7Wtv/Mb4iuZSYzCdAw8wI1wfdGKs2Lw3d+dvRA03l08km+G2u4aA2h7Wc/Y@freebsd.org X-Gm-Message-State: AOJu0Yz6cEC96zPMtXoTZAAliQuhDeHuSmIprteMgSkDljvAXqMomXR+ eRGwQFhlpLjWjeNuP6DfcIT1Y6z6iyC4JgjTQXQNQE627wTWh+BlCuz4O8YqAZTMo6VqMdboNaJ +FYS6IUjNzy49B+0Z9PeMKIqrIop9fnZChUY3ILQwrg== X-Gm-Gg: ASbGncsWJICV1lA1ARf59eHCoUaDsghmc3cg7qc8I8XsPUvX9l355LaChDfQuyk4mLy 4z1+3bMQCRpshltEhUcy6htcAdezDjvZRtSLnngyYXuDIgmt9rjwHR7WzSRKtLGz0GzmIuIBX3n uAatnEFNVMvBLQCuGTjG9q//pKmTrgbf7Iq2s0YHltrGNfoCbiSEcpDONOo+GFZbnS058+adEfY NItmPkWEbqsyLMzqX1HT4bHGWCNmHadBh3+1CSKIkN1jDEv9w== X-Google-Smtp-Source: AGHT+IF+8chhkviHf+qOo8ARrf4MTkxZHE8bfKsB7+cRoHWri/QWd7A7LpJVGbgvyi/r+9zKwsGOxiQBwicq14nHYqw= X-Received: by 2002:a17:90b:5848:b0:32d:b98f:f733 with SMTP id 98e67ed59e1d1-32db98ff894mr5639236a91.29.1757539408887; Wed, 10 Sep 2025 14:23:28 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202509071842.587IgHbm001636@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 10 Sep 2025 15:23:18 -0600 X-Gm-Features: Ac12FXyg2y3LACBbSEyzEZcJs1JHVGRy6fWaWw-_E79MX1d6ouHVfHq154fHPtk Message-ID: Subject: Re: git: 11ace56fa030 - main - contrib/libxo: fix API header files inclusions in C++ source files To: Phil Shafer Cc: Konstantin Belousov , Ka Ho Ng , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000255110063e79082c" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cMYZq5BP6z47jV --000000000000255110063e79082c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 10, 2025 at 1:49=E2=80=AFPM Phil Shafer wrot= e: > It's not freebsd-specific, but __BEGIN_DECLS isn't freebsd only. If it's > reasonably portable, it makes sense to use it. I see it in macOS, glibc, > and linux (at least some of dists). > I believe that it came from 4.4BSD and spread from there. Warner > Thanks, > Phil > > > > > On 10 Sep 2025, at 0:31, Konstantin Belousov wrote: > > > Would it be better to use __BEGIN_DECLS? I am not completely sure due t= o > > > > contrib/, but libxo is FreeBSD-specific enough already. > --000000000000255110063e79082c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Sep 10,= 2025 at 1:49=E2=80=AFPM Phil Shafer <phil@juniper.net> wrote:
It's not freebsd-specific, but __BEGIN_DECLS isn'= t freebsd only.=C2=A0 If it's reasonably portable, it makes sense to us= e it.=C2=A0 I see it in macOS, glibc, and linux (at least some of dists).

I believe that it came from 4.4BSD and s= pread=C2=A0from there.

Warner
=C2=A0
Thanks,
=C2=A0Phil




On 10 Sep 2025, at 0:31, Konstantin Belousov wrote:

> Would it be better to use __BEGIN_DECLS? I am not completely sure due = to
>
> contrib/, but libxo is FreeBSD-specific enough already.
--000000000000255110063e79082c--