From owner-svn-src-all@FreeBSD.ORG Wed Jun 13 02:24:31 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8C42106566C; Wed, 13 Jun 2012 02:24:31 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) by mx1.freebsd.org (Postfix) with ESMTP id 84B618FC0C; Wed, 13 Jun 2012 02:24:31 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 226DC25D39FF; Wed, 13 Jun 2012 02:24:30 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 3D2BABE8046; Wed, 13 Jun 2012 02:24:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id t44GFgHhL6Kl; Wed, 13 Jun 2012 02:24:28 +0000 (UTC) Received: from orange-en1.sbone.de (orange-en1.sbone.de [IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id A8CFEBE8044; Wed, 13 Jun 2012 02:24:27 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: "Bjoern A. Zeeb" In-Reply-To: <201206122137.q5CLbReK077123@svn.freebsd.org> Date: Wed, 13 Jun 2012 02:24:26 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <59C39E5A-C63D-490C-B260-E00A4D90E213@lists.zabbadoz.net> References: <201206122137.q5CLbReK077123@svn.freebsd.org> To: Konstantin Belousov X-Mailer: Apple Mail (2.1084) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r236976 - head/sbin/fsck_ffs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2012 02:24:31 -0000 On 12. Jun 2012, at 21:37 , Konstantin Belousov wrote: > Author: kib > Date: Tue Jun 12 21:37:27 2012 > New Revision: 236976 > URL: http://svn.freebsd.org/changeset/base/236976 >=20 > Log: > For incompleted block allocations or frees, the inode block count = usage > must be recalculated. The blk_check pass of suj checker explicitely = marks > inodes which owned such blocks as needing block count adjustment. But > ino_adjblks() is only called by cg_trunc pass, which is performed = before > blk_check. As result, the block use count for such inodes is left = wrong. > This causes full fsck run after journaled run to still find = inconsistencies > like 'INCORRECT BLOCK COUNT I=3D14557 (328 should be 0)' in phase 1. >=20 > Fix this issue by running additional adj_blk pass after blk_check, = which > updates the field. >=20 > Reviewed by: jeff, mckusick Thanks a lot! /bz --=20 Bjoern A. Zeeb You have to have visions! It does not matter how good you are. It matters what good you do!