From owner-svn-ports-head@freebsd.org Tue Nov 24 12:29:08 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 367CCA355BE; Tue, 24 Nov 2015 12:29:08 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 26C8C1A9B; Tue, 24 Nov 2015 12:29:08 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 25E9716C3; Tue, 24 Nov 2015 12:29:08 +0000 (UTC) Date: Tue, 24 Nov 2015 12:29:08 +0000 From: Alexey Dokuchaev To: marino@freebsd.org Cc: Baptiste Daroussin , Gerald Pfeifer , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r402352 - head/lang/gcc Message-ID: <20151124122908.GA21620@FreeBSD.org> References: <201511241019.tAOAJMTF049917@repo.freebsd.org> <20151124110152.GA78748@FreeBSD.org> <5654459E.40100@marino.st> <20151124115156.GA3457@FreeBSD.org> <20151124122024.GD76516@ivaldir.etoilebsd.net> <5654567C.8000101@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5654567C.8000101@marino.st> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2015 12:29:08 -0000 On Tue, Nov 24, 2015 at 01:22:20PM +0100, John Marino wrote: > On 11/24/2015 1:20 PM, Baptiste Daroussin wrote: > > [...] > > And legacy make is still used on 9.x[.] Please terminate sentences properly, thank you. > But this is not fatal on 9.x. All it does is print the comment during > the build, which really isn't bad. and FWIW, I think indented comments > looks much better, but it's obviously subjective. Indented comments look better in C code, where indentation does not carry any semantic difference. FWIW, I also used to like indented comments in Makefiles this way until I realized how horribly wrong it is, felt ashamed of myself, and promised never ever do this again. :-) ./danfe