From owner-cvs-all Wed Jan 9 12:31:57 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 233DB37B405; Wed, 9 Jan 2002 12:31:53 -0800 (PST) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id g09KVn342956; Wed, 9 Jan 2002 15:31:49 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20020109185225.A23551@walton.maths.tcd.ie> References: <200201091736.g09HarQ62030@freefall.freebsd.org> <20020109185225.A23551@walton.maths.tcd.ie> Date: Wed, 9 Jan 2002 15:31:47 -0500 To: David Malone , Daniel Eischen From: Garance A Drosihn Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.1 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 6:52 PM +0000 1/9/02, David Malone wrote: >On Wed, Jan 09, 2002, Daniel Eischen wrote: > > Initialze a stack variable with NULL to unbreak buildworld with -Wall. >> I don't know about anyone else, but the compiler was always aborting >> on this stupid warning, and has been doing so for weeks. > >Are you sure this is needed any more? I think I fixed the order of >the warning flags to prevent the compiler whining a few days ago. >(Also, I think you must have had local changes to the tree to >provoke this 'cos I've been building world without problems.) Well, it doesn't *hurt* to initialize that variable, except maybe that it breaks style(9) to initialize it in the declaration instead of down a few lines. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message