From owner-cvs-src@FreeBSD.ORG  Mon Jun 13 00:01:18 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 05E9216A41C;
	Mon, 13 Jun 2005 00:01:18 +0000 (GMT)
	(envelope-from marcel@xcllnt.net)
Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C4B4A43D1D;
	Mon, 13 Jun 2005 00:01:17 +0000 (GMT)
	(envelope-from marcel@xcllnt.net)
Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250])
	by ns1.xcllnt.net (8.13.3/8.13.3) with ESMTP id j5D01HKT015400;
	Sun, 12 Jun 2005 17:01:17 -0700 (PDT)
	(envelope-from marcel@xcllnt.net)
In-Reply-To: <200506122233.j5CMX60W020136@repoman.freebsd.org>
References: <200506122233.j5CMX60W020136@repoman.freebsd.org>
Mime-Version: 1.0 (Apple Message framework v622)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <cdae9246c661a61c3f81ecd36481ff27@xcllnt.net>
Content-Transfer-Encoding: 7bit
From: Marcel Moolenaar <marcel@xcllnt.net>
Date: Sun, 12 Jun 2005 17:01:14 -0700
To: Jeff Roberson <jeff@FreeBSD.org>
X-Mailer: Apple Mail (2.622)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys bio.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2005 00:01:18 -0000


On Jun 12, 2005, at 3:33 PM, Jeff Roberson wrote:

> jeff        2005-06-12 22:33:06 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/sys              bio.h
>   Log:
>    - switch_point is now unused.  This doesn't break module binary 
> compatability
>      since the structure is shrinking, not growing.

Not true. An array of bio_queue_head will be broken by this change.
Other breakages may be caused by having the field remain uninitialized
or clobbered from the perspective of a module. Passing by value is
also broken.

If ABI breakage is a concern, this change better be reverted.

-- 
  Marcel Moolenaar         USPA: A-39004          marcel@xcllnt.net