From owner-cvs-all@FreeBSD.ORG Wed Feb 21 23:07:26 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3D1D916A400; Wed, 21 Feb 2007 23:07:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 9391B13C4A3; Wed, 21 Feb 2007 23:07:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l1LN76gX097565; Wed, 21 Feb 2007 18:07:12 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Andrew Gallatin Date: Wed, 21 Feb 2007 18:06:37 -0500 User-Agent: KMail/1.9.1 References: <200702151721.l1FHLWno019525@repoman.freebsd.org> <20070221102702.B91427@xorpc.icir.org> <17884.43824.818734.325125@grasshopper.cs.duke.edu> In-Reply-To: <17884.43824.818734.325125@grasshopper.cs.duke.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200702211806.38708.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 21 Feb 2007 18:07:13 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2623/Wed Feb 21 16:50:55 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Luigi Rizzo , Luigi Rizzo , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/arm/xscale/ixp425 ixp425_npe.c src/sys/dev/ipw if_ipw.c if_ipwvar.h src/sys/dev/isp isp_freebsd.h src/sys/dev/iwi if_iwi.c if_iwivar.h src/sys/dev/mxge if_mxge.c src/sys/kern subr_firmware.c src/sys/sys firmware.h src/sys/tools fw_stub.awk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2007 23:07:26 -0000 On Wednesday 21 February 2007 15:27, Andrew Gallatin wrote: > Luigi Rizzo writes: > > On Wed, Feb 21, 2007 at 01:22:28PM -0500, Andrew Gallatin wrote: > > > > > > Luigi Rizzo writes: > > ,,, > > > > i am not sure i follow you here... > > > > Of course when you drop the lock you risk that the underlying > > > > data structure is manipulated (or in the worst case freed), > > > > but usually you can avoid this with something like > > > > > > > > > > > > sc->flags |= LEAVE_ME_ALONE > > > > UNLOCK > > > > > > Sorry, I hadn't noticed that iwi set a flag like that. I was > > > > not everywhere. i am sure that there are parts that are not protected. > > That's the kind of thing I'm afraid of. > > > In any case i think we should relabel the thread or potentially > > interested people will miss the content being misled by the subject! > > I'm satisfied to let it drop, now that I've vented a little :) > > Back on, more or less, track: Can you commit my hack to the kernel > linker which lets firmware(9) work from attach() without deadlock? Can you try http://www.FreeBSD.org/~jhb/patches/kld_recurse.patch It compiles but I have not booted it. It makes the various system calls ignore files that aren't marked as fully linked yet to avoid the races with dropping the lock and then drops the lock while it runs through all the sysinit's. Sorry this took so long. My grumpy side is frustrated that other people just want to commit hacks and not invest time in coming up with cleaner solutions hoping someone else will clean up their hack some day in the future, but I'm still getting over a bout with the flu, so I'm likely extra grumpy. -- John Baldwin