From owner-freebsd-bugs@FreeBSD.ORG Tue Jul 20 12:30:01 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D387106567C for ; Tue, 20 Jul 2010 12:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5310F8FC1E for ; Tue, 20 Jul 2010 12:30:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6KCU1C3030138 for ; Tue, 20 Jul 2010 12:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6KCU197030137; Tue, 20 Jul 2010 12:30:01 GMT (envelope-from gnats) Resent-Date: Tue, 20 Jul 2010 12:30:01 GMT Resent-Message-Id: <201007201230.o6KCU197030137@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Petr Lampa Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6ECD9106566B for ; Tue, 20 Jul 2010 12:23:53 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 5EC988FC19 for ; Tue, 20 Jul 2010 12:23:53 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o6KCNqDH021581 for ; Tue, 20 Jul 2010 12:23:52 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o6KCNqBe021573; Tue, 20 Jul 2010 12:23:52 GMT (envelope-from nobody) Message-Id: <201007201223.o6KCNqBe021573@www.freebsd.org> Date: Tue, 20 Jul 2010 12:23:52 GMT From: Petr Lampa To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/148785: twa driver doesn't pass proper max. io size to cam X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2010 12:30:01 -0000 >Number: 148785 >Category: kern >Synopsis: twa driver doesn't pass proper max. io size to cam >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jul 20 12:30:01 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Petr Lampa >Release: STABLE8 >Organization: BUT FIT >Environment: FreeBSD XXX 8.1-PRERELEASE FreeBSD 8.1-PRERELEASE #6: Tue Jul 20 13:58:44 CEST 2010 XXX:/usr/src/sys/i386/compile/VIDEO5 i386 >Description: LSI/3ware cards are able to process 128KB requests (TW_CL_MAX_IO_SIZE), but the twa driver doesn't set maxio field in XPT_PATH_INQ request, so cam will use DFLTPHYS (64KB). >How-To-Repeat: >Fix: One line change at XPT_PATH_INQ processing in tw_osl_cam.c (line 453): *** tw_osl_cam.c 2010-07-20 14:06:37.000000000 +0200 --- /root/tw_osl_cam.c 2010-07-20 14:06:24.000000000 +0200 *************** *** 450,455 **** --- 450,456 ---- path_inq->transport_version = 2; path_inq->protocol = PROTO_SCSI; path_inq->protocol_version = SCSI_REV_2; + path_inq->maxio = TW_CL_MAX_IO_SIZE; ccb_h->status = CAM_REQ_CMP; xpt_done(ccb); break; Functionality verified both with 9500 and 9650SE. >Release-Note: >Audit-Trail: >Unformatted: