From owner-freebsd-current@freebsd.org Wed May 22 22:08:19 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5BCB15B8D1E for ; Wed, 22 May 2019 22:08:19 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5779F6D3F2; Wed, 22 May 2019 22:08:18 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f44.google.com with SMTP id z4so3222070iol.0; Wed, 22 May 2019 15:08:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=x1Oyf94DWUEerHdm43CJJUHEjLaZVjxPsRon/OX3SSg=; b=s8KBAI8dOQ4/4lNJk+07VSd2I4XT06JX9STHVAuFWjaQpcz2WOmVhvtv1KDG3NDnSw 66iCxZ6hGu0bFhisrOqeYXXxUYyVGGOWr+KUEwgVQt+qMmRntSRX03pbVKbc9jzZCe37 MHCCtBLPr6S0ryfPSWPf6H3ac9julMH03mkVKuLYljkrNq2Uj1b5VjFYwZQfbSnZ/znQ /xoyENwMhG7wRzgmePoENWeMl4MVujSywQzhd5w89kPoc+y64kei8lzLRL8sDZnUf0Qh rTHRRzG9QRToMjLgXB26+bK/bv1QdBJGH1su+O5dD0b+DPmkxwN3Aj32Z7/YRRCqVd53 rqFQ== X-Gm-Message-State: APjAAAXYu3ML/yeAJx4qz2e31Iu9gn/ddoSTdWIbs76/E4duU4wfFyF5 T5RQCLo2OYaGyLjMFc2GFvFiuJ3T X-Google-Smtp-Source: APXvYqxbWibPG4eJqFuFVGO1nEQQe0B2j25os18WJ6lvC4/BOikb2IGI/2CKn1YdQjOKkL0OtMDmQw== X-Received: by 2002:a6b:b654:: with SMTP id g81mr4634332iof.34.1558562578465; Wed, 22 May 2019 15:02:58 -0700 (PDT) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com. [209.85.166.45]) by smtp.gmail.com with ESMTPSA id r12sm3369224itb.2.2019.05.22.15.02.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 15:02:58 -0700 (PDT) Received: by mail-io1-f45.google.com with SMTP id f22so3152556iol.11; Wed, 22 May 2019 15:02:58 -0700 (PDT) X-Received: by 2002:a6b:c411:: with SMTP id y17mr278715ioa.265.1558562578097; Wed, 22 May 2019 15:02:58 -0700 (PDT) MIME-Version: 1.0 References: <6ec62e4d-9f93-ffe1-646c-3846c9308334@FreeBSD.org> <20190522175133.GC2748@kib.kiev.ua> <84e3001b-646d-b1d9-f206-577d63f79bf1@FreeBSD.org> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Wed, 22 May 2019 15:02:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Weirdness when writing to pseudofs file To: Johannes Lundberg Cc: FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5779F6D3F2 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.166.44 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-5.39 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.97)[-0.975,0]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[44.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.40)[ip: (-6.22), ipnet: 209.85.128.0/17(-3.45), asn: 15169(-2.28), country: US(-0.06)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 22:08:20 -0000 On Wed, May 22, 2019 at 1:58 PM Johannes Lundberg wrote: > > It seems, a single '>' will cause it to try to create the file (even > > though it already exists) and that fails (kern_openat). > > > I would guess because of > > https://github.com/freebsd/freebsd/blob/master/sys/fs/pseudofs/pseudofs_vnops.c#L1042 > > struct vop_vector pfs_vnodeops = { > ... > .vop_create = VOP_EOPNOTSUPP, > ... > } kern_openat -> vn_open(_cred) should only call VOP_CREATE if namei() cannot find the named vnode (ni_vp == NULL). Otherwise, it should just invoke VOP_OPEN. This suggests there might be a lookup bug in pfs? Tracing VOPs as Mark suggested seems like a good next step. Best, Conrad