From owner-freebsd-bugs@FreeBSD.ORG  Wed Nov  3 10:10:11 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4DF4F106566C
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  3 Nov 2010 10:10:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 3C6B48FC0C
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  3 Nov 2010 10:10:11 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oA3AABUf012850
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 3 Nov 2010 10:10:11 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oA3AABhl012849;
	Wed, 3 Nov 2010 10:10:11 GMT (envelope-from gnats)
Date: Wed, 3 Nov 2010 10:10:11 GMT
Message-Id: <201011031010.oA3AABhl012849@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Jaakko Heinonen <jh@FreeBSD.org>
Cc: 
Subject: Re: misc/151861: dlclose() of library causes separately opened
 libraries to unload as well
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Jaakko Heinonen <jh@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Nov 2010 10:10:11 -0000

The following reply was made to PR misc/151861; it has been noted by GNATS.

From: Jaakko Heinonen <jh@FreeBSD.org>
To: Kostik Belousov <kostikbel@gmail.com>
Cc: Arjan van Leeuwen <freebsd-maintainer@opera.com>,
	bug-followup@freebsd.org, kan@freebsd.org
Subject: Re: misc/151861: dlclose() of library causes separately opened
 libraries to unload as well
Date: Wed, 3 Nov 2010 12:06:49 +0200

 On 2010-11-02, Kostik Belousov wrote:
 > Why do you think that your patch is not correct ?
 
 Well, I didn't say that I think it's incorrect. :)
 
 > I feel that more explicit handling of the state of the DAG is cleaner.
 
 I don't disagree but there is a problem with your patch. If an object
 has the DF_1_NODELETE flag set, dag is initialized in
 load_needed_objects(). In this case the reference count isn't correctly
 bumped in dlopen() because dag_inited is already set.
 
 (BTW. I think that there shouldn't be the ref_dag(obj1) call in
 load_needed_objects(). Now the reference count is increased twice in the
 nodelete case.)
 
 > --- a/libexec/rtld-elf/rtld.c
 > +++ b/libexec/rtld-elf/rtld.c
 > @@ -1275,8 +1275,11 @@ init_dag(Obj_Entry *root)
 >  {
 >      DoneList donelist;
 >  
 > +    if (root->dag_inited)
 > +	    return;
 
 Why init_dag() should be allowed to be called multiple times for an
 object?
 
 Thanks.
 -- 
 Jaakko