From owner-freebsd-multimedia@FreeBSD.ORG Tue Jul 10 13:20:47 2007 Return-Path: X-Original-To: multimedia@FreeBSD.org Delivered-To: freebsd-multimedia@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8C45D16A492; Tue, 10 Jul 2007 13:20:47 +0000 (UTC) (envelope-from Yuriy.Tsibizov@gfk.com) Received: from mx2.gfk.ru (mx2.gfk.ru [84.21.231.139]) by mx1.freebsd.org (Postfix) with ESMTP id 8FF8113C48C; Tue, 10 Jul 2007 13:20:46 +0000 (UTC) (envelope-from Yuriy.Tsibizov@gfk.com) Received: from ex.hhp.local by mx2.gfk.ru (MDaemon PRO v9.6.0) with ESMTP id md50000212676.msg; Tue, 10 Jul 2007 17:07:55 +0400 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-MimeOLE: Produced By Microsoft Exchange V6.5 Date: Tue, 10 Jul 2007 17:10:47 +0400 Message-ID: <78664C02FF341B4FAC63E561846E3BCC0A145E@ex.hhp.local> In-Reply-To: <20070710093829.34mqbekao4wwww4s@webmail.leidinger.net> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: Audio driver template thread-index: AcfC51vShbTc1zVqS/ybJ4mUnhlP0gACyp3A References: <20070710093829.34mqbekao4wwww4s@webmail.leidinger.net> From: "Yuriy Tsibizov" To: "Alexander Leidinger" , "Christopher Davis" X-Spam-Processed: mx2.gfk.ru, Tue, 10 Jul 2007 17:07:55 +0400 (not processed: message from valid local sender) X-MDRemoteIP: 10.0.0.30 X-Return-Path: Yuriy.Tsibizov@gfk.com X-Envelope-From: Yuriy.Tsibizov@gfk.com X-MDAV-Processed: mx2.gfk.ru, Tue, 10 Jul 2007 17:07:56 +0400 Cc: freebsd-hackers@FreeBSD.org, multimedia@FreeBSD.org Subject: RE: Audio driver template X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2007 13:20:47 -0000 > > http://people.freebsd.org/~cg/template.c > > > > Thought I would take a look at the audio driver template as > > part of my task to modernize drivers, soc2007. I would simplify > > the read and write functions to avoid using the bus tag and > > handle, but I'm not sure what else to do to bring it up to date. > > > > How else can it be improved? >=20 > And you should clarify what kind of improvements are valid for your =20 > SoC work. Somehow I doubt that adding shiny new features (like hps =20 > suggested) is part of the goal for your work. I think it's more like =20 > bringing existing drivers up-to-par with currently available generic =20 > driver interfaces, isn't it? >=20 > I also think examples for suspend/resume stuff should be added. =20 > /sys/dev/sound/pci/atiixp.c has suspend and resume methods if=20 > you want =20 > an example. >=20 > You could also review the locking, as it changed a little bit =20 > recently, I think. >=20 > Apart from the atiixp driver the envy42, emu10kx and HDA drivers can =20 > also serve as examples for what is the most current in the sound =20 > subsystem in FreeBSD. Maybe you can gain some more hints from=20 > them (I =20 > think the template is not very up-to-date compared to them). emu10kx is bad example, because it uses a lot of "hacks", like=20 ac97 codec emulation. Yuriy.