From owner-svn-src-head@freebsd.org Wed Jun 3 22:19:53 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5A26F2F4FC3; Wed, 3 Jun 2020 22:19:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49cjyK1bWbz3cZd; Wed, 3 Jun 2020 22:19:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3181715493; Wed, 3 Jun 2020 22:19:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 053MJqYU032590; Wed, 3 Jun 2020 22:19:52 GMT (envelope-from jhb@FreeBSD.org) Received: (from jhb@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 053MJqYl032589; Wed, 3 Jun 2020 22:19:52 GMT (envelope-from jhb@FreeBSD.org) Message-Id: <202006032219.053MJqYl032589@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jhb set sender to jhb@FreeBSD.org using -f From: John Baldwin Date: Wed, 3 Jun 2020 22:19:52 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r361777 - head/sys/dev/cxgbe/crypto X-SVN-Group: head X-SVN-Commit-Author: jhb X-SVN-Commit-Paths: head/sys/dev/cxgbe/crypto X-SVN-Commit-Revision: 361777 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2020 22:19:53 -0000 Author: jhb Date: Wed Jun 3 22:19:52 2020 New Revision: 361777 URL: https://svnweb.freebsd.org/changeset/base/361777 Log: Explicitly zero IVs on the stack. Reviewed by: delphij Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D25057 Modified: head/sys/dev/cxgbe/crypto/t4_crypto.c Modified: head/sys/dev/cxgbe/crypto/t4_crypto.c ============================================================================== --- head/sys/dev/cxgbe/crypto/t4_crypto.c Wed Jun 3 22:18:21 2020 (r361776) +++ head/sys/dev/cxgbe/crypto/t4_crypto.c Wed Jun 3 22:19:52 2020 (r361777) @@ -751,6 +751,7 @@ ccr_blkcipher(struct ccr_softc *sc, struct ccr_session /* XXX: TODO backpressure */ t4_wrq_tx(sc->adapter, wr); + explicit_bzero(iv, sizeof(iv)); return (0); } @@ -1069,6 +1070,7 @@ ccr_eta(struct ccr_softc *sc, struct ccr_session *s, s /* XXX: TODO backpressure */ t4_wrq_tx(sc->adapter, wr); + explicit_bzero(iv, sizeof(iv)); return (0); } @@ -1351,6 +1353,7 @@ ccr_gcm(struct ccr_softc *sc, struct ccr_session *s, s /* XXX: TODO backpressure */ t4_wrq_tx(sc->adapter, wr); + explicit_bzero(iv, sizeof(iv)); return (0); } @@ -1818,6 +1821,7 @@ ccr_ccm(struct ccr_softc *sc, struct ccr_session *s, s /* XXX: TODO backpressure */ t4_wrq_tx(sc->adapter, wr); + explicit_bzero(iv, sizeof(iv)); return (0); }