Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 3 Jun 2020 22:19:52 +0000 (UTC)
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r361777 - head/sys/dev/cxgbe/crypto
Message-ID:  <202006032219.053MJqYl032589@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jhb
Date: Wed Jun  3 22:19:52 2020
New Revision: 361777
URL: https://svnweb.freebsd.org/changeset/base/361777

Log:
  Explicitly zero IVs on the stack.
  
  Reviewed by:	delphij
  Sponsored by:	Netflix
  Differential Revision:	https://reviews.freebsd.org/D25057

Modified:
  head/sys/dev/cxgbe/crypto/t4_crypto.c

Modified: head/sys/dev/cxgbe/crypto/t4_crypto.c
==============================================================================
--- head/sys/dev/cxgbe/crypto/t4_crypto.c	Wed Jun  3 22:18:21 2020	(r361776)
+++ head/sys/dev/cxgbe/crypto/t4_crypto.c	Wed Jun  3 22:19:52 2020	(r361777)
@@ -751,6 +751,7 @@ ccr_blkcipher(struct ccr_softc *sc, struct ccr_session
 	/* XXX: TODO backpressure */
 	t4_wrq_tx(sc->adapter, wr);
 
+	explicit_bzero(iv, sizeof(iv));
 	return (0);
 }
 
@@ -1069,6 +1070,7 @@ ccr_eta(struct ccr_softc *sc, struct ccr_session *s, s
 	/* XXX: TODO backpressure */
 	t4_wrq_tx(sc->adapter, wr);
 
+	explicit_bzero(iv, sizeof(iv));
 	return (0);
 }
 
@@ -1351,6 +1353,7 @@ ccr_gcm(struct ccr_softc *sc, struct ccr_session *s, s
 	/* XXX: TODO backpressure */
 	t4_wrq_tx(sc->adapter, wr);
 
+	explicit_bzero(iv, sizeof(iv));
 	return (0);
 }
 
@@ -1818,6 +1821,7 @@ ccr_ccm(struct ccr_softc *sc, struct ccr_session *s, s
 	/* XXX: TODO backpressure */
 	t4_wrq_tx(sc->adapter, wr);
 
+	explicit_bzero(iv, sizeof(iv));
 	return (0);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202006032219.053MJqYl032589>