From owner-svn-src-all@FreeBSD.ORG Thu Sep 30 20:37:47 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49EF3106567A for ; Thu, 30 Sep 2010 20:37:47 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id A96C88FC15 for ; Thu, 30 Sep 2010 20:37:46 +0000 (UTC) Received: (qmail 27768 invoked by uid 399); 30 Sep 2010 20:37:45 -0000 Received: from localhost (HELO ?192.168.0.142?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 30 Sep 2010 20:37:45 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4CA4F503.4020907@FreeBSD.org> Date: Thu, 30 Sep 2010 13:37:23 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 To: Ed Maste References: <201009291308.o8TD8NHo009975@svn.freebsd.org> <4CA42F56.4070604@FreeBSD.org> <20100930130812.GA79354@sandvine.com> In-Reply-To: <20100930130812.GA79354@sandvine.com> X-Enigmail-Version: 1.2a1pre OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r213270 - head/etc/rc.d X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2010 20:37:47 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 9/30/2010 6:08 AM, Ed Maste wrote: | On Wed, Sep 29, 2010 at 11:33:58PM -0700, Doug Barton wrote: | |> -----BEGIN PGP SIGNED MESSAGE----- |> Hash: SHA256 |> |> On 9/29/2010 6:08 AM, Ed Maste wrote: |> | Author: emaste |> | Date: Wed Sep 29 13:08:23 2010 |> | New Revision: 213270 |> | URL: http://svn.freebsd.org/changeset/base/213270 | ... | |> Could you please back this (and your related changes) out, and evaluate |> Jeremy's script? I, and other users have evaluated it for some time now |> and found it effective; and I'd like to see it committed, especially now |> that Jeremy has updated it. | | Backing this out doesn't improve anything, so I'm not going to do that. | This change is an improvement to what's in the tree today, and the | original author of this script agreed with the approach. I will review | Jeremy's script as time permits; if it is a viable replacement for | defaultroute then we can just replace defaultroute with it, and my | change can then end up in /dev/null. Thanks for taking the time to chat with me about this on IRC. As a result of our discussion I am withdrawing my request for you to back this code out. Meanwhile, for future reference, when someone asks you to hold off on committing something and to explore other options first what we have done in the past is NOT to go ahead and commit the code anyway, then initiate a discussion about possible modifications. It's a matter of respect, and good committer relations. And yes, you can laugh all you want about me being the one to point this out, but that doesn't invalidate my point. Doug - -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (MingW32) iQEcBAEBCAAGBQJMpPUDAAoJEFzGhvEaGryENWsH/A6CfJwSs+Snq8bdZkEuKWjT LLFYGWqI9mtaeC6NusjOKX7yyYZDHKm4r544tisxNShQiUU/HMBAzuTWdR7YV2rl SslHoTX1hifenF0e08eog3ZjbJVze3yUeREd/gN7DLlb+i6OtqzK+JCAUsY1bp1C augagpralfpHfBo6bXa/1Xy1E8w6dzZ1Lh1uaqUfwHN1G9vF/UHuuSD5+MI9nv1s R1uBydN+X3KROM5Iz7xqiaLzD+ny52uKikYOhvi6GckEJlC4qg9y6uRr01HWNKaq PCSC/xLa/mU6Yfze/srl4yvBi+TYffAhY5y5L3046cBFiK1n2Q+X+fC9GdcGxKA= =t93b -----END PGP SIGNATURE-----