From owner-svn-src-all@freebsd.org Wed Jul 15 00:02:33 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 206EF9A1D35; Wed, 15 Jul 2015 00:02:33 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 335A61D93; Wed, 15 Jul 2015 00:02:32 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from zeta.ixsystems.com (unknown [12.229.62.2]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id DD0811C742; Tue, 14 Jul 2015 17:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1436918552; x=1436932952; bh=Tji20FCl99g29h3dlZ+JlFHMz3pbUkZbFrldBBGkMsI=; h=Date:From:Reply-To:To:CC:Subject:References:In-Reply-To; b=nL7Vin0SyPzL+7+zgAFUfxyRe71XYf/2fCUlFEIFPtMfF80X9FtaE9y2MdzpR7ivP Eng6ZdlcwHXRt68izLM/3bZY+H7iNygeNrEHVJFjttN7E3jDH3YdrT4XofpXATJfha Omq6pgottaTRqSMGsUPoiLgBahh96WxJZZJ3OR4A= Message-ID: <55A5A317.9000008@delphij.net> Date: Tue, 14 Jul 2015 17:02:31 -0700 From: Xin Li Reply-To: d@delphij.net Organization: The FreeBSD Project MIME-Version: 1.0 To: Pedro Giffuni , d@delphij.net, Garrett Cooper , Baptiste Daroussin CC: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285552 - head/usr.bin/xargs References: <201507141916.t6EJGEG1083928@repo.freebsd.org> <48222CD1-7087-4C9A-A586-71F6A37A601C@gmail.com> <55A574BA.4090700@delphij.net> <55A591C8.1030105@FreeBSD.org> In-Reply-To: <55A591C8.1030105@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 00:02:33 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 07/14/15 15:48, Pedro Giffuni wrote: > > > On 07/14/15 15:44, Xin Li wrote: >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 >> >> On 07/14/15 13:29, Garrett Cooper wrote: >>> On Jul 14, 2015, at 12:16, Baptiste Daroussin >>> wrote: >>> >>>> Author: bapt Date: Tue Jul 14 19:16:14 2015 New Revision: >>>> 285552 URL: https://svnweb.freebsd.org/changeset/base/285552 >>>> >>>> Log: Convert atoi(3) to stronum(3) which allows to arguments >>>> and report proper errors to the users >>> Is strtonum preferred over strtoll, etc? >> strtonum(3) is a wrapper of strtoll() and provides more >> functionality like range checking, so I think the answer would be >> yes. > > There is only the issue that strtonum(3) is non-standard so I have > resisted the temptation to blindly replace atoi(3) in existing > code. Well, that's true, but what Baptiste done was to address a specific issue with the existing code (to provide better error message) so I don't think that counts as a simple wholesale replacement from one API to another API. Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1.6 (FreeBSD) iQIcBAEBCgAGBQJVpaMXAAoJEJW2GBstM+nspRwP/2hRY54SkxknEyCVP8+l7U6W kmtX4ErcVHBVri+9oW04GFX6Pu5/8uTZZTh7ALLzGIUprBqGhcDwbTTD+9Gw/ha7 PKliR33zYoqIMg7DNHXI8nSXh2nq4AaTucWnO9Vl0vNtRR8jDvmzCF03ukHv4JlX 2ES/sL2ruToI6wwk9fWnLqJ3lhZO2aXVmbrLyzsWiaQCKNCKWe/LhP1IhGwTFvra HmOKXl+FC0PosYQ8LBhiu8GSuK3wWmoIWOCAQ5TmhHD4UFU57sBS2bTxXekrradu PEnz0W+ZCpgy5XXot6VBXOjoLU/Dm3RYt4un/ot11y/FZCVnh+RfbzJXFJUSuQ6A 6hyqBi3NoSD5k0e8ei9frJennDT23ucuffPKaYC9EMCjki7sJCf9Nn3t0x3sBdvZ q3EJyIdAHmRQZxessRnkJGZA74kJBHa3yzIATBL58EpDFIJABK2reomEhwNEBnKS V01xQzMm4YqJ5dy89ZE81SD8+3b9N2HNnMoA7LsJGa3hcVVOnfKNPDMYH8YEpZu0 JwQOBg2k04AkwfWqkW97/av1nOmwg5H7/Zm7dEGU6KcPl49NzfnnH5WYsBT8R2N3 8tAMwddNzNAWKvDya0qH0sPFw3YiyLtPA+e7S54iDroTyiWCXBuYLfzQEkC+bQzX zxsjdL+FPfBuK76YuM1l =MYtY -----END PGP SIGNATURE-----