From owner-cvs-all@FreeBSD.ORG Tue Jan 30 22:36:20 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C0A4F16A56C; Tue, 30 Jan 2007 22:36:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 62A5513C442; Tue, 30 Jan 2007 22:36:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l0UMa9QD072006; Tue, 30 Jan 2007 17:36:15 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Pawel Jakub Dawidek Date: Tue, 30 Jan 2007 16:36:36 -0500 User-Agent: KMail/1.9.1 References: <20070128202917.5B67916A5A6@hub.freebsd.org> <20070129194158.N32458@fledge.watson.org> <20070129201938.GF87767@garage.freebsd.pl> In-Reply-To: <20070129201938.GF87767@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701301636.38175.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 30 Jan 2007 17:36:16 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2506/Tue Jan 30 14:50:40 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, arch@freebsd.org, Nate Lawson Subject: Re: cvs commit: src/sys/geom/eli g_eli.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2007 22:36:21 -0000 On Monday 29 January 2007 15:19, Pawel Jakub Dawidek wrote: > I fully agree that there should be a clean KPI for this. What you > proposed if fine. Because of lack of such KPI geli has to handle HTT > CPUs which are turned off by default in releases also by abusing > scheduler internals. KPI you proposed would allow me to remove those > hacks. And I'm really all for it. > > What you and Scott are missing is that when I implement a GEOM class, > I'm using what is available to do my work. I'm not going to educate > myself how schedulers work, implement nice and clean KPI to use it in > my class. I'm not saying it wouldn't be great to be able to do so, but I > don't have time for everything, unfortunately, and you guys should > understand that very well. Something you seem to be missing though is that in general it's nice to not just endulge in an endless series of hacks in your specific area of the system. IWBN to at some point devote some time to help fix more general problems that will benefit the system as a whole rather than adding hacks that just benefit yourself and require someone else to clean up when they eventually add the more-architected solution. We are all very busy, but if everyone just did hacks and never put any effort into improving the general infrastructure, we'd have a royal mess. -- John Baldwin