From owner-cvs-all@FreeBSD.ORG Wed Sep 22 16:35:44 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7FE6816A4CE; Wed, 22 Sep 2004 16:35:44 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5203043D31; Wed, 22 Sep 2004 16:35:44 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i8MGcAKf029089; Wed, 22 Sep 2004 09:38:11 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i8MGcA6a029088; Wed, 22 Sep 2004 09:38:10 -0700 Date: Wed, 22 Sep 2004 09:38:10 -0700 From: Brooks Davis To: Brian Fundakowski Feldman Message-ID: <20040922163810.GA28683@odin.ac.hmc.edu> References: <200409220859.i8M8xgwb022928@repoman.freebsd.org> <20040922130052.GA3407@green.homeunix.org> <20040922150105.GA17806@odin.ac.hmc.edu> <20040922153007.GA91347@green.homeunix.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Content-Disposition: inline In-Reply-To: <20040922153007.GA91347@green.homeunix.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: Brooks Davis cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Sep 2004 16:35:44 -0000 --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 22, 2004 at 11:30:07AM -0400, Brian Fundakowski Feldman wrote: > On Wed, Sep 22, 2004 at 08:01:05AM -0700, Brooks Davis wrote: > > On Wed, Sep 22, 2004 at 09:00:52AM -0400, Brian Fundakowski Feldman wro= te: > > > On Wed, Sep 22, 2004 at 08:59:42AM +0000, Brooks Davis wrote: > > > > brooks 2004-09-22 08:59:42 UTC > > > >=20 > > > > FreeBSD src repository > > > >=20 > > > > Modified files: > > > > sys/net if.c=20 > > > > Log: > > > > Fix a LOR where ifconf() used copyout while holding a mutex. Thi= s LOR > > > > was seen when configuring addresses on interfaces using ifconfig.= This > > > > patch has been verified to work with over eight thousand addresses > > > > assigned to an interface. > > > > =20 > > > > LOR id: 031 > > >=20 > > > You really need to be running with INVARIANTS if you plan on committi= ng > > > kernel code, or people are likely to get angry when their systems cra= sh > > > for stupid reasons. > >=20 > > Sorry about that. Pass the pointy had please. :-( >=20 > No hard feelings, since I'm used to having a new issue or two every kernel > upgrade, but this really should be a lesson to anyone listening that kern= el > development without INVARIANTS (and sometimes WITNESS) is a big no-no. Yah, I've added INVARIANTS back to my laptop kernel in perforce to avoid this particular mistake in the future. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBUapyXY6L6fI4GtQRAh5nAJwMPDtO1xpn6DuJQxnywSqmQLWcgQCgvT9A 2M2XIujYwD1HcsxJqkJ67Jc= =lf9X -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--