Date: Thu, 01 Nov 2007 11:15:21 +0800 From: David Xu <davidxu@FreeBSD.org> To: Andrey Chernov <ache@nagual.pp.ru> Cc: current@FreeBSD.org Subject: Re: non-functional backout for review Message-ID: <472944C9.5020304@freebsd.org> In-Reply-To: <20071101025937.GB94332@nagual.pp.ru> References: <20071101025937.GB94332@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrey Chernov wrote: > Some people complaints that new check in __isctype() is not human readable > and requests for backout. Compiler gives almost identical code for old and > new excepting non-optimized case where non-human readable one wins. I am a > bit tired to change it forth and back, so ask for final consensus here. > > Old one > > return (_c < 0 || _c >= 128) ? 0 : > > New one (requests for backout) > > return (_c & ~0x7F) ? 0 : > I will use a version which compiler can generate optimized code. the name __isctype already tells what the function is doing. :-) Regards, David Xu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?472944C9.5020304>