From owner-freebsd-ports-bugs@freebsd.org Tue Apr 17 20:33:17 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 91FC6F98DF2 for ; Tue, 17 Apr 2018 20:33:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 29B93726A3 for ; Tue, 17 Apr 2018 20:33:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 9F8D8F98DEF; Tue, 17 Apr 2018 20:33:16 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 300DAF98DDD for ; Tue, 17 Apr 2018 20:33:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE67C72678 for ; Tue, 17 Apr 2018 20:33:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id CDEF12A8D6 for ; Tue, 17 Apr 2018 20:33:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w3HKXEM8020183 for ; Tue, 17 Apr 2018 20:33:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w3HKXEjM020182 for ports-bugs@FreeBSD.org; Tue, 17 Apr 2018 20:33:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 227150] [NEW PORT] sysutils/rw: Block device and byte copying program similar to dd Date: Tue, 17 Apr 2018 20:33:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: 0mp@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 20:33:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227150 --- Comment #5 from Mateusz Piotrowski <0mp@FreeBSD.org> --- (In reply to jsmith from comment #4) Cool! Thanks for updating the patch. There are, however, still a couple of issues: * The license is invalid. See Chapter 5.7 of the Porter's Handbook[1] for a list of valid license symbols. * There's probably no need to define do-install and do-build. The distribu= tion of rw has a Makefile, which does everything for us. Hint: you might want to define post-install in order to use ${STRIP_CMD}.[2]=20 * There are a lot of style problems. You my list them using portlint and t= hen fix warnings until portlint says "looks fine.". You may install portlint wi= th `pkg install ports-mgmt/portlint`. [1]: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/licenses= .html [2]: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/install.= html --=20 You are receiving this mail because: You are the assignee for the bug.=