From owner-freebsd-current@FreeBSD.ORG Sat Jan 29 15:10:22 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9DC116A4CE for ; Sat, 29 Jan 2005 15:10:22 +0000 (GMT) Received: from mailout08.sul.t-online.com (mailout08.sul.t-online.com [194.25.134.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id 63D6943D3F for ; Sat, 29 Jan 2005 15:10:22 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from fwd09.aul.t-online.de by mailout08.sul.t-online.com with smtp id 1CuuEu-0004x8-03; Sat, 29 Jan 2005 16:10:20 +0100 Received: from Andro-Beta.Leidinger.net (bLI9yOZJYeDFVizHNFUE9DIZvF5Z6eb99eJByLsw-MAN4OhRJZDUcV@[217.229.221.88]) by fmrl09.sul.t-online.com with esmtp id 1CuuEq-1l7wMi0; Sat, 29 Jan 2005 16:10:16 +0100 Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) j0TFA5RN065288 for ; Sat, 29 Jan 2005 16:10:05 +0100 (CET) (envelope-from Alexander@Leidinger.net) Date: Sat, 29 Jan 2005 16:10:22 +0100 From: Alexander Leidinger To: current@freebsd.org Message-ID: <20050129161022.0de822fe@Magellan.Leidinger.net> X-Mailer: Sylpheed-Claws 1.0.0 (GTK+ 1.2.10; i386-portbld-freebsd6.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ID: bLI9yOZJYeDFVizHNFUE9DIZvF5Z6eb99eJByLsw-MAN4OhRJZDUcV@t-dialin.net X-TOI-MSGID: d2c30a6b-6da1-42cf-a504-6236dd026b95 Subject: We have a lot of duplicated code in the kernel X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jan 2005 15:10:23 -0000 Hi, http://www.leidinger.net/FreeBSD/simian-20-sys-20050129.log (253k) contains a log of duplicated code in /sys (-current as of today). The file starts with files with 20 consecutive lines of duplicated code and ends with two files which share 1108 lines of code. If I let the program detect 6 consecutive lines of duplicated code, it is also able to detect possible code reuse in the same file, but it also prints a lot of "noise" then. I've filtered the list for some false positives (twa_fwimg, trlld?m, if_patm_rtables), if someone else notices some more files please tell me about them and I add them to the filter. Bye, Alexander. -- It is easier to fix Unix than to live with NT. http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7