From owner-freebsd-bugs@freebsd.org Sat Jul 18 15:45:46 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 73A1F36D323 for ; Sat, 18 Jul 2020 15:45:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4B8C4p2WMrz4RLR for ; Sat, 18 Jul 2020 15:45:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 5650F36D047; Sat, 18 Jul 2020 15:45:46 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 561AC36D322 for ; Sat, 18 Jul 2020 15:45:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B8C4p1dmtz4RJP for ; Sat, 18 Jul 2020 15:45:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0190DD0BD for ; Sat, 18 Jul 2020 15:45:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 06IFjjXa030296 for ; Sat, 18 Jul 2020 15:45:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 06IFjjkA030295 for bugs@FreeBSD.org; Sat, 18 Jul 2020 15:45:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 248070] kernel panic sysctl -a Date: Sat, 18 Jul 2020 15:45:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lampa@fit.vutbr.cz X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jul 2020 15:45:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248070 Bug ID: 248070 Summary: kernel panic sysctl -a Product: Base System Version: 12.1-STABLE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: lampa@fit.vutbr.cz uname -a FreeBSD xxx 12.1-STABLE FreeBSD 12.1-STABLE r363310 xxxx amd64 sysctl -a kern.ostype: FreeBSD kern.osrelease: 12.1-STABLE kern.osrevision: 199506 kern.version: FreeBSD 12.1-STABLE r363310 VOJEN kern.maxvnodes: 620153 kern.maxproc: 38036 kern.maxfiles: 1044518 kern.argmax: 524288 kern.securelevel: -1 kern.hostname: xxx kern.hostid: 2119532645 kern.clockrate: { hz =3D 1000, tick =3D 1000, profhz =3D 8128, stathz =3D 1= 27 } <<<---- panic at eip 0x20:0xfffffff8058946b bt pget() at pget+0x200/frame 0xfffffe009f4987e0 sysctl_kern_proc_kstack() at sysctl_kern_proc_kstack+0x27 sysctl_root_handler_locked() at sysctl_root_handler_locked+0x7d sysctl_root() at sysctl_root+0x192 userland_sysctl() ... Source of panic is mismerge of kern_proc.c in 363038 at line 413, original = was: } else { if (pid <=3D PID_MAX) { ... } else if ((flags & PGET_NOTID) =3D=3D 0) { p =3D pfind_tid_locked(pid); } else { p =3D NULL; } revision 363038: } else { if (pid <=3D PID_MAX) { ... } else if ((flags & PGET_NOTID) =3D=3D 0) { td1 =3D tdfind(pid, -1); if (td1 !=3D NULL) p =3D td1->td_proc; } If tdfind() fails, p is not reset to NULL and also NOTID case was lost. Mer= ge missed assignment p =3D NULL before if (pid <=3D PID_MAX): } else { p =3D NULL; /* THIS STATEMENT IS IN HEAD, NOT IN STABLE */ if (pid <=3D PID_MAX) { ... } else if ((flags & PGET_NOTID) =3D=3D 0) { td1 =3D tdfind(pid, -1); if (td1 !=3D NULL) p =3D td1->td_proc; } With this change, sysctl -a no longer panics. --=20 You are receiving this mail because: You are the assignee for the bug.=