From owner-freebsd-current@FreeBSD.ORG Sun Sep 7 22:34:38 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E08115CD; Sun, 7 Sep 2014 22:34:37 +0000 (UTC) Received: from mail-pd0-x22e.google.com (mail-pd0-x22e.google.com [IPv6:2607:f8b0:400e:c02::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A704A1563; Sun, 7 Sep 2014 22:34:37 +0000 (UTC) Received: by mail-pd0-f174.google.com with SMTP id v10so5432337pde.5 for ; Sun, 07 Sep 2014 15:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=iO8D49qJwjKihLgznPl6QMufGY4CPAf4FJEihSzBSCA=; b=V5sCzidK5osSZ8niPaDUYtjnrmtiHn9belAHE65WdtawWRPjCxQ4u8791LH/h4wOcJ d1RbFzIE2AzJcQ0arnvYJOulTMLUSnmfc3vcT6WKhsvJ3r61j2K5ZIl3fJgf4uuPOT85 Rkrr2pjuMH6zoGV1b8GdPhWjZ5rFnqJpf35kecrggVGCdborkT9/oMWnyjPUojymoS5p GinMlrzX/JW/wm5KpxYkB1uLzGbXiVszmgzWSxj3+F1AQ+gxIN+RSQoHGi2PQr3uKQ86 32n8y19/5bfum8CJCZz51Dc3lF2VKhsmqaPh7GmI4O9YBSIZfsbNpS93Oqhbwr4LyZJ/ O7gQ== X-Received: by 10.68.89.36 with SMTP id bl4mr15114332pbb.17.1410129277122; Sun, 07 Sep 2014 15:34:37 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:644f:a9af:8645:807a? ([2601:8:ab80:7d6:644f:a9af:8645:807a]) by mx.google.com with ESMTPSA id om6sm7257801pdb.89.2014.09.07.15.34.36 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 07 Sep 2014 15:34:36 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_526BD5B1-739A-4B03-9320-430430E6958A"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: NO INET6 warning From: yaneurabeya@gmail.com In-Reply-To: <20140907210802.GA48287@hub.FreeBSD.org> Date: Sun, 7 Sep 2014 15:34:35 -0700 Message-Id: References: <1410123815.10027.18.camel@bruno> <20140907210802.GA48287@hub.FreeBSD.org> To: Glen Barber X-Mailer: Apple Mail (2.1878.6) Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Sep 2014 22:34:38 -0000 --Apple-Mail=_526BD5B1-739A-4B03-9320-430430E6958A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Sep 7, 2014, at 14:08, Glen Barber wrote: > On Sun, Sep 07, 2014 at 02:03:35PM -0700, Sean Bruno wrote: >> make[4]: "/home/sbruno/bsd/fbsd_head/sys/modules/if_gif/Makefile" = line >> 12: warning: Couldn't read shell's output for >> "cat = /home/sbruno/bsd/obj/mips/mips.mips/home/sbruno/bsd/fbsd_head/sys/WZR-300H= P/opt_inet6.h" >>=20 >>=20 >> Shouldn't this cat be done in a saner way? >>=20 >=20 > This is done quite often throughout the tree, and bmake(1) does not = like > it when there is no value assigned from the '!=3D' expansion. >=20 > The fix I've seen most commonly done is to echo a newline after the > assignment, such as: >=20 > Index: sys/modules/if_gif/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/modules/if_gif/Makefile (revision 271215) > +++ sys/modules/if_gif/Makefile (working copy) > @@ -9,7 +9,7 @@ KMOD=3D if_gif > SRCS=3D if_gif.c in_gif.c opt_inet.h opt_inet6.h opt_mrouting.h >=20 > .if defined(KERNBUILDDIR) > -OPT_INET6!=3D cat ${KERNBUILDDIR}/opt_inet6.h > +OPT_INET6!=3D cat ${KERNBUILDDIR}/opt_inet6.h; echo > .if empty(OPT_INET6) > MK_INET6_SUPPORT=3Dno > .endif Shouldn=92t this all be removed and replaced with equivalent = logic provided by kern.opts.mk? Thanks! -Garrett --Apple-Mail=_526BD5B1-739A-4B03-9320-430430E6958A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUDN17AAoJEMZr5QU6S73e2SgIAK5NsVZt3dNPCmKyBgs5VA7d kR4RJdabmdE3+oaMH6YY8IKOvwoXtgvuABSS07UN1HWauDzkl/O6E63axlmGxYYh B8T06rsPLUjTTROxuNssSV0B8upz5XC3Md/9K4dbYivTPWb2P9oFDX8HxNjQHkay JZYR229n05be6V3tvJfvvbN2jhbEvep1B8g8Bpoo+CiJcyHOKyN9cKkVtPDPIa4l JEqBzQb7bhXU6fIglMgmryYVQiLs7R17OVhQH73HVovoFdrFgQOP4qplgnNhV6Gm +awmrmE1VbP/q2ETNON3do16BfpeaZshv9fB2E80GciOXtVjOZJR7qbsZqdWLDg= =fa2Z -----END PGP SIGNATURE----- --Apple-Mail=_526BD5B1-739A-4B03-9320-430430E6958A--