From owner-freebsd-arch Thu Sep 19 15:29:15 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2E63B37B401 for ; Thu, 19 Sep 2002 15:29:14 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3888743E75 for ; Thu, 19 Sep 2002 15:29:13 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id IAA24603; Fri, 20 Sep 2002 08:29:02 +1000 Date: Fri, 20 Sep 2002 08:37:42 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Mark Murray Cc: arch@FreeBSD.ORG Subject: Re: More lint work for share/mk/ (review, please) In-Reply-To: <200209192115.g8JLF57s003495@grimreaper.grondar.org> Message-ID: <20020920083332.E3384-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 19 Sep 2002, Mark Murray wrote: > > % - ${LINT} ${LINTFLAGS} ${CFLAGS:M-[DIU]*} ${.ALLSRC} | more 2>&1 > > % + ${LINT} ${LINTFLAGS} ${CFLAGS:M-[DIU]*} ${.ALLSRC} > > > > I wonder what this pipeline is for. I once thought that it was to combine > > stdout with stderr to work around the bug that lint prints some messages > > on stderr, but it is wrong for that -- the correct way to combine stdin > > with stderr is "2>&1" before any pipe. > > This got discussed to death last time. It is minor and mostly irrelevant; > its here for consistency with another similar removal. Locally I just > put it back in the .mk file as I disagreed with that removal too, and put it back in some places (mainly as a reminder to fix it properly). > lint: > ${LINT} .... ${.ALLSRC} 2>&1 | cat > > so I can > > # make lint | less > > I don't feel stronly enough to discuss this any further. Take it > out, leave it in. Either way suits me. :-) The "| cat" part brings out my anti-useless process reflex :-). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message