From owner-freebsd-ports-bugs@freebsd.org Wed Apr 13 00:38:44 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BCCA5B0C2D7 for ; Wed, 13 Apr 2016 00:38:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ACF94157A for ; Wed, 13 Apr 2016 00:38:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u3D0cifX005025 for ; Wed, 13 Apr 2016 00:38:44 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 208754] games/assaultcube: Fix build with libc++ 3.8.0 Date: Wed, 13 Apr 2016 00:38:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2016 00:38:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D208754 lightside changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|maintainer-feedback?(lights |maintainer-feedback+ |ide@gmx.com) | --- Comment #1 from lightside --- Hello, Dimitry Andric. Thanks for your patch. I found, that "hand-rolled" round() function was removed by upstream for development version also: https://github.com/assaultcube/AC/commit/752950989b4e286459ca9aee3d61a868d7= b20fa4 -8<-- fix some errors and warnings for GCC 6 * do not use std::abs() because math.h includes one, that converts ints to double. Use own iabs(), which directly uses labs() instead. * don't use the word "gamma" as name for variables * don't use a homebrew round() function -->8- There are also some upstream fixes for Clang warnings, some of which already included: https://github.com/assaultcube/AC/commit/6e4b23734f115888ce73907a85739ec833= a333fd Therefore, I propose to use mentioned upstream fixes (adapted for current 1.2.0.2 version), which includes your fix for round() function. The proposed patch attached to the following message. --=20 You are receiving this mail because: You are the assignee for the bug.=