Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Mar 2014 23:35:32 +0100 (CET)
From:      Tijl Coosemans <tijl@FreeBSD.org>
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/187801: [patch] science/mpqc: support LDFLAGS (fixes libghemical)
Message-ID:  <201403202235.s2KMZWhj095609@kalimero.tijl.coosemans.org>
Resent-Message-ID: <201403202240.s2KMe03b046584@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         187801
>Category:       ports
>Synopsis:       [patch] science/mpqc: support LDFLAGS (fixes libghemical)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 20 22:40:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Tijl Coosemans
>Release:        FreeBSD 11.0-CURRENT i386
>Organization:
>Environment:
>Description:
The attached patch makes the port use LDFLAGS from Mk/Uses/fortran.mk
such that the libraries and executables are linked with the runtime
libraries from lang/gcc instead of the base system.

This fixes this build error in libghemical:
http://beefy2.isc.freebsd.org/bulk/91amd64-default/2014-03-19_18h55m31s/logs/errors/libghemical-3.0.0_2.log

Tested on redports:
mpqc: https://redports.org/buildarchive/20140320200601-29431/
mpqc-mpich: https://redports.org/buildarchive/20140320202454-12424/
libghemical: https://redports.org/buildarchive/20140320202534-78415/
>How-To-Repeat:
>Fix:

--- mpqc.patch begins here ---
Index: science/mpqc/Makefile
===================================================================
--- science/mpqc/Makefile	(revision 348672)
+++ science/mpqc/Makefile	(working copy)
@@ -3,7 +3,7 @@
 
 PORTNAME=	mpqc
 PORTVERSION=	2.3.1
-PORTREVISION=	18
+PORTREVISION=	19
 CATEGORIES=	science parallel
 MASTER_SITES=	SF
 
@@ -59,7 +59,8 @@ CXXFLAGS=	-O3 -tpp7 -xMKW -Vaxlib
 CONFIGURE_ARGS+=--with-cc=${CC} \
 		--with-cxx=${CXX} \
 		--with-f77=${FC} \
-		--with-libdirs=-L${LOCALBASE}/lib \
+		--with-include="-I${WRKDIR} -I${LOCALBASE}/include" \
+		--with-libdirs="-L${LOCALBASE}/lib ${LDFLAGS}" \
 		--with-blas="${BLAS}" \
 		--with-lapack="${LAPACK}" \
 		--with-coptflags="${CFLAGS}" \
@@ -71,15 +72,9 @@ CONFIGURE_ARGS+=--with-cc=${CC} \
 CONFIGURE_ARGS+=--with-libs="-lsvml"
 .endif
 .if defined(WITH_MPICH)
-CONFIGURE_ARGS+=--with-libdirs="-L${LOCALBASE}/lib -L${LOCALBASE}/lib"\
-		--enable-always-use-mpi
+CONFIGURE_ARGS+=--enable-always-use-mpi
 CONFIGURE_ENV+=	PTHREAD_LIBS="${PTHREAD_LIBS}"
 .endif
-.if defined(WITH_MPICH)
-CONFIGURE_ARGS+=--with-include="-I${LOCALBASE}/include -I${WRKDIR} -I${LOCALBASE}/include"
-.else
-CONFIGURE_ARGS+=--with-include="-I${WRKDIR} -I${LOCALBASE}/include"
-.endif
 
 MPQC_COMMAND=	${PREFIX}/bin/mpqc
 
Index: science/mpqc/files/patch-LocalMakefile.in
===================================================================
--- science/mpqc/files/patch-LocalMakefile.in	(revision 348672)
+++ science/mpqc/files/patch-LocalMakefile.in	(working copy)
@@ -5,10 +5,10 @@
    LTLINK = $(LIBTOOL) --mode=link
    ifneq ($(BUILDID),)
 -    LTLINKLIBOPTS = -rpath $(libdir) -release $(BUILDID) -version-info $(SC_SO_VERSION)
-+    LTLINKLIBOPTS = %%EXTRARPATH%% -rpath $(libdir) -release $(BUILDID) -version-info $(SC_SO_VERSION)
++    LTLINKLIBOPTS = $(LDFLAGS) -rpath $(libdir) -release $(BUILDID) -version-info $(SC_SO_VERSION)
    else
 -    LTLINKLIBOPTS = -rpath $(libdir) -version-info $(SC_SO_VERSION)
-+    LTLINKLIBOPTS = %%EXTRARPATH%% -rpath $(libdir) -version-info $(SC_SO_VERSION)
++    LTLINKLIBOPTS = $(LDFLAGS) -rpath $(libdir) -version-info $(SC_SO_VERSION)
    endif
    LTLINKBINOPTS =
    LTCOMP = $(LIBTOOL) --mode=compile
--- mpqc.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403202235.s2KMZWhj095609>