From owner-svn-src-head@freebsd.org Sat May 13 16:39:17 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 704F9D6B397 for ; Sat, 13 May 2017 16:39:17 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2A13DCC3 for ; Sat, 13 May 2017 16:39:17 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x229.google.com with SMTP id p24so54828867ioi.0 for ; Sat, 13 May 2017 09:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=HbZCQ/YfeUyhHxvJ86bwGonNQZZ2UR7bYETppkJ+Ubw=; b=CQ4Bj25tNul6OL92dZMz4MuiQ9pDi8Hmy/+BA+4TR3tNt4xvpodfd3crDfUt9NhsHb zfSwRkx5WYdgMrO2hBj/Uh6GCIVne9cng5RCQwqqcwjbx4/JW8hGL9B+lsyMJsV49gIu WBy9UuAwlSVre42h7H8eI6BByaCGmDiyzipryiGAMaKp+ciyNLX7W85nbkae+BiXfLPI 7pWGbJtxZaobKOWsEB0eSzAUlTBNUHuj4wEjyGOpAwYQX87Nwk6J5RMkpG6f5S0pXqfu b0MGDOykEMLHy8p/Xq+19Jm5FKLu8AkOzVJr/j76JWFvCngXDPxaT1yq3ve0RXyCCG53 P/Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=HbZCQ/YfeUyhHxvJ86bwGonNQZZ2UR7bYETppkJ+Ubw=; b=q5XJxOZFyvSHA5aetLjwkHUz9M913ffkGFNd1PVcctjX75pso+0AYd9/eUPDyvG9AX KsUt0PEsTPpQvSEWWvf6rC9EcIGrKdOu/5pLTEgvtkZiV1zE/XoPDBPiyvTseMkgVU2o 9D5OKALeNQA0mxzwMtW/pR1qEvrMogf4LISVZg6M221kfj7RRVxZT8awo3KY7SNSoW9X +31ieUMAHsNVVz5EM7q2js+qWc3hIQUxiBbO9uEffsDqaaNrRM2k8QuAmyFUEE58zvDS qPAme0GKI/00F9DXie9mPHO1rQ7eS0/9nZc8AZGUgi1AB1dJIOMtFOuQKK6bHVfKScZw WQ+Q== X-Gm-Message-State: AODbwcBO4jPZTBVUNZnRgdvME6XtM0Foi4QbM/E2HZpfeKfsD1jViUnJ PMAXgPhFC6Z4P58pLQm6GQUyRvuAtg== X-Received: by 10.107.85.4 with SMTP id j4mr9557338iob.218.1494693556442; Sat, 13 May 2017 09:39:16 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.126.6 with HTTP; Sat, 13 May 2017 09:39:15 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:5c7c:18cc:3900:fa11] In-Reply-To: References: <201705131537.v4DFbgWV045290@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Sat, 13 May 2017 10:39:15 -0600 X-Google-Sender-Auth: XhPw2u20NXQRJme6PFYXNoSOaWg Message-ID: Subject: Re: svn commit: r318250 - in head: etc etc/newsyslog.conf.d etc/syslog.d tools/build/mk To: Ngie Cooper Cc: "Rodney W. Grimes" , Ngie Cooper , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 May 2017 16:39:17 -0000 On Sat, May 13, 2017 at 10:32 AM, Ngie Cooper wrote: > >> On May 13, 2017, at 09:29, Ngie Cooper wrote: >> >> On May 13, 2017, at 08:37, Rodney W. Grimes wrote: >> >>>> Author: ngie >>>> Date: Sat May 13 03:10:50 2017 >>>> New Revision: 318250 >>>> URL: https://svnweb.freebsd.org/changeset/base/318250 >>>> >>>> Log: >>>> Handle the logfiles in newsyslog and syslogd conditionally, based on >>>> src.conf(5) knobs >>>> >>>> This will allow consumers of FreeBSD to use the unmodified configuration >>>> files out of the box more than previously. >>> >>> What about simply generating proper newsyslog.conf and syslog.conf based >>> on the the MK_ values rather than change the visible administration >>> interface that has finger memory, ansible, and puppet support? >> >> - My employer doesn't use puppet on its appliances. >> - Files snapshotted in time bitrot (which was the case with our configs, which is part of the reason behind this change. couldn't you have an Isilion config file in the appropriate directory instead? And use the default newsyslog / syslog config files? >> - It's really easy to screw up a mergemaster call if you edit the files, and install the stock version which removes the edits. > > Also, programmatically removing the entries means you have to bake the metadata into etc/Makefile, which is already complicated enough as-is. Why do you care about removing them at all? They are no-ops if the files don't exist. Why not just always install all these files is where I'm going with this... Warner