From owner-freebsd-net@FreeBSD.ORG Sun Mar 14 05:24:49 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4810E1065676 for ; Sun, 14 Mar 2010 05:24:49 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id D6A688FC26 for ; Sun, 14 Mar 2010 05:24:48 +0000 (UTC) Received: (qmail 31088 invoked by uid 399); 14 Mar 2010 05:24:48 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 14 Mar 2010 05:24:48 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4B9C731F.4040604@FreeBSD.org> Date: Sat, 13 Mar 2010 21:24:47 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.7) Gecko/20100218 Thunderbird/3.0.1 MIME-Version: 1.0 To: freebsd-net@freebsd.org References: <604f76121003130425u62764f59wa88b398f15540b61@mail.gmail.com> In-Reply-To: <604f76121003130425u62764f59wa88b398f15540b61@mail.gmail.com> X-Enigmail-Version: 1.0.1 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [ping6] freeaddrinfo() X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Mar 2010 05:24:49 -0000 On 03/13/10 04:25, Earl Lapus wrote: > Hi, > > I was browsing through the ping6 code and I noticed that one > particular call to getaddrinfo() didn't have a freeaddrinfo() pair. > All calls to getaddrinfo() should have an equivalent freeaddrinfo(), right? > > Attached is a patch that "tries-to-resolve" this very small issue > (applies cleanly on an 8.0p2 kernel source). > Also, I'm not not 100% sure if that is the correct place to call > freeaddrinfo() - I hope someone on the list would be kind enough to > have look. For all such issues, please file a PR first so it doesn't get lost. When you get the PR confirmation back, feel free to alert the list to its existence. hth, Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/