Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 06 Oct 2015 16:41:57 -0700
From:      Rui Paulo <rpaulo@me.com>
To:        "Alexander V. Chernikov" <melifaro@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r288657 - head/sys/netinet6
Message-ID:  <1444174917.6210.43.camel@me.com>
In-Reply-To: <201510040821.t948LGH7000421@repo.freebsd.org>
References:  <201510040821.t948LGH7000421@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2015-10-04 at 08:21 +0000, Alexander V. Chernikov wrote:
> Author: melifaro
> Date: Sun Oct  4 08:21:15 2015
> New Revision: 288657
> URL: https://svnweb.freebsd.org/changeset/base/288657
> 
> Log:
>   Add __noinline attribute to several functions to ease dtrace
> instrumentation
> 

What instrumentation?  Is there a DTrace script in userland that uses
these functions?  If not, this should not have been committed as you
just made the code slower.  This is one of those changes that should be
kept in your own repository.

-- 
Rui Paulo




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1444174917.6210.43.camel>