From owner-svn-ports-head@FreeBSD.ORG Tue Jul 2 23:38:21 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 29AF4D6; Tue, 2 Jul 2013 23:38:21 +0000 (UTC) (envelope-from lippemail@gmail.com) Received: from mail-ve0-x22b.google.com (mail-ve0-x22b.google.com [IPv6:2607:f8b0:400c:c01::22b]) by mx1.freebsd.org (Postfix) with ESMTP id A76891C1A; Tue, 2 Jul 2013 23:38:20 +0000 (UTC) Received: by mail-ve0-f171.google.com with SMTP id b10so5381757vea.30 for ; Tue, 02 Jul 2013 16:38:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=ln0uxWwAeVXdTv36kKQpo+w9iBz04TG/edjsB1h5Bqg=; b=kF4JWUBm0EWlMJG3ygyAepXGdxNXAfmXAm9cviXcESbXwKpjENYbjVy0k61PnkRYej eBDRhk/Z5iTwQzSR85LVXONcBZJZDRpbyrA0LIZvGNN5Q+P7zCSawQsnYXs00CZzMt9m xUejQi+dxwSt8GKPmD5FJvb/58qq8V26ho7WomY80n0J2UFkqy0FZfQ5gEmUgzM0UP1S cvtZYY6L0h5QA7hHTKSujS1r2AuPIJCndXH+w7Tn2pb/No+90VJj5jcl3mCkMZFYhQE+ q2/LKXU69aGgNP0n6Hvqw4zYbDhEtG7GH9YDPpZIj5y67ugWZj2klOKtlmxQegW03/B2 doLQ== MIME-Version: 1.0 X-Received: by 10.52.94.45 with SMTP id cz13mr3283711vdb.9.1372808300132; Tue, 02 Jul 2013 16:38:20 -0700 (PDT) Sender: lippemail@gmail.com Received: by 10.52.163.45 with HTTP; Tue, 2 Jul 2013 16:38:20 -0700 (PDT) In-Reply-To: <2F9D29C1-259B-41F0-9C67-00AAE5DBA69E@adamw.org> References: <201306282045.r5SKjaZb090161@svn.freebsd.org> <20130701011908.GB9325@FreeBSD.org> <2F9D29C1-259B-41F0-9C67-00AAE5DBA69E@adamw.org> Date: Tue, 2 Jul 2013 20:38:20 -0300 X-Google-Sender-Auth: xyV1GniIFww8EMVvBNBvsM_rReU Message-ID: Subject: Re: svn commit: r321982 - in head/net: . hanstunnel hanstunnel/files From: Felippe de Meirelles Motta To: Adam Weinberger Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jul 2013 23:38:21 -0000 I talked with other committers these days and I must admit that I was wrong, so I sent new patches for PRs that I am dealing with and if the submitter or maintainer does not reply, I can use the timeout for resolve these issues in a better way . Did not want to disrespect or offend anyone's and bsam@ and danfe@ comments were very well received by me and I see this as constructive criticism, just as you did it now. I know the efforts of those who are conducting a cleanup in CATEGORIES (e.g. OPTIONS). I think I include something wrong in these categories that have already been corrected, would be wrong. Thanks lippe@ On Tue, Jul 2, 2013 at 8:00 PM, Adam Weinberger wrote: > On 2013-07-01, at 13:30, Felippe de Meirelles Motta > wrote: > > > danfe@, bsam@ and others thanks for the points mentioned, some I had > noticed, others I had really missed, but I just could not manipulate the > outcome of the patches without proper approval of the maintainer, because > this is your role. > > Sorry but I totally disagree. As committers, we (supposedly) know what is > best, and the right way to do things. External maintainers are submitters; > they can make mistakes and you can catch and fix them, within reason. On > the whole, people are quite appreciative when you commit their patch > quickly with small modifications, rather than dragging the PR for weeks > while you wait for a spelling fix. > > I mean, don't go changing the logic or anything, but all the time I close > PR's with "Committed, but I fixed MASTER_SITE to use the source forge > macro" or whatever. Never once have I heard anything except "Thank you," > and best of all, next time they submit a PR they get it right. > > I really don't understand why you'd rather commit something you know to be > wrong. DTRT and don't be a pedant. > > # Adam > > > -- > Adam Weinberger > adamw@adamw.org > http://www.adamw.org > > >