From owner-svn-src-head@freebsd.org Fri Feb 1 01:05:52 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 279AA14BE426; Fri, 1 Feb 2019 01:05:52 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 65B5284BE0; Fri, 1 Feb 2019 01:05:51 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-lj1-x233.google.com with SMTP id u89-v6so4397030lje.1; Thu, 31 Jan 2019 17:05:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=albf8FPXM+MAOueeawzz/byxL3GtaH+ISDDtSEju0fo=; b=AFz5p1FihVr0q/efoaWVwCidKjYjEHJvWvvQY3CxGekugK2HvyQKH2mtz4tO0odYZS 15zxVFBD5O9gWGfVoJF9cT40osVHsQWyi688m5+BMB/4sJav5ef35JRPG0n6LZkoVkGQ axFm+xsI1GQDb4nK+15UmQzv3wPk53MY1px1XShgw/gIsBYD+90wOkn708ef28Hl46nh ss5uaWLnvwmEeeGJp8ylKp9lnDvx7MtTB6kG7UVmf2+87CKcPoJtDMRZk1peVikpRHpr Ro+0vIWN1GSAI4VFMw3+nNuuPzc1Ip/849RdJIbrGfN4EvUDPfgqI5w7JRY1FVkEKOuI C3eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=albf8FPXM+MAOueeawzz/byxL3GtaH+ISDDtSEju0fo=; b=MTzk1NW2v1gc7Kx89dI3E8EXflHV6SijyX2+xLTV4AZ5bE1qk2y8Lrnk06HRxL7Ea6 XBukF0fCKkEJ2mIrRctoHWCxMHLQyWFfXRZLDgHyadcxQjVcW6WT/NXZJn29TuObk5/W dHCGpKqzcK1yCgb5Ha6BMhX3CrkvG47HeKXoG6oTGItZf3GBPKZtKFuWbqVsI0J+It7D jdav1pJlRERZqY/jPd++JxhFRVCRGyxFEviFMyBkKt4ngToPCeWM8TWOd3wv91YXseMl BgYUFyE0RKoIbKg9ENu3e7QHCMT68EAm7ft2ajJdHFQ8v3I+hunaPOOC+PSzXxv83j1U HcuQ== X-Gm-Message-State: AJcUuke0qmuMdzcKnp/saJPaihMdz+xPWxmufJxyFAl/iqeNbwnhLZ6B D3U2ZXoGeg34bswj9gnyQyhi3mkiOde1jATjaag= X-Google-Smtp-Source: ALg8bN7RKKQstrXoo80jAPHcejDfa5Txd+JqUWiQrsiw8KOZ1Xj9AmLlV+E4ekgs3cr8tccDRlqycyJmcjHeI88ce4M= X-Received: by 2002:a2e:12d0:: with SMTP id 77-v6mr29213292ljs.132.1548983149696; Thu, 31 Jan 2019 17:05:49 -0800 (PST) MIME-Version: 1.0 References: <201901312332.x0VNWJ6o016057@repo.freebsd.org> <20190131234609.GZ24863@kib.kiev.ua> <20190201010117.GA24863@kib.kiev.ua> In-Reply-To: <20190201010117.GA24863@kib.kiev.ua> Reply-To: araujo@freebsd.org From: Marcelo Araujo Date: Fri, 1 Feb 2019 09:05:37 +0800 Message-ID: Subject: Re: svn commit: r343634 - head/usr.sbin/bhyve To: Konstantin Belousov Cc: Marcelo Araujo , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 65B5284BE0 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.968,0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 01:05:52 -0000 Em sex, 1 de fev de 2019 =C3=A0s 09:01, Konstantin Belousov escreveu: > On Fri, Feb 01, 2019 at 08:40:11AM +0800, Marcelo Araujo wrote: > > Em sex, 1 de fev de 2019 =C3=A0s 08:36, Warner Losh > escreveu: > > > > > > > > > > > On Thu, Jan 31, 2019, 4:46 PM Konstantin Belousov > > wrote: > > > > > >> On Thu, Jan 31, 2019 at 11:32:19PM +0000, Marcelo Araujo wrote: > > >> > Author: araujo > > >> > Date: Thu Jan 31 23:32:19 2019 > > >> > New Revision: 343634 > > >> > URL: https://svnweb.freebsd.org/changeset/base/343634 > > >> > > > >> > Log: > > >> > Mostly a cosmetic change to replace strlen with strnlen. > > >> This is not cosmetic, and more, for instance the usage() part of the > > >> change > > >> does not make any sense to me. > > >> > > > > > > I specifically objected as well and was blown off. What gives? > > > > > > > I have asked you feedback and got none! I will revert the usage() chang= es > > later then. > > I noted the usage() chunk because it is the first one in the commit and > I stopped after I see the obvious issues with it, not because it is the > only wrong part. > Are you implying that all the patch is wrong? I have no problem to revert it at all if you give me the right reason, it was basically a port from another project that also uses bhyve. Best, --=20 --=20 Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)