From owner-svn-src-all@FreeBSD.ORG  Sun May 26 21:48:41 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id F0B687E8;
 Sun, 26 May 2013 21:48:40 +0000 (UTC)
 (envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72])
 by mx1.freebsd.org (Postfix) with ESMTP id BB20BEF7;
 Sun, 26 May 2013 21:48:40 +0000 (UTC)
Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149])
 by mail.dawidek.net (Postfix) with ESMTPSA id B4746204;
 Sun, 26 May 2013 23:44:25 +0200 (CEST)
Date: Sun, 26 May 2013 23:51:25 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Glen Barber <gjb@FreeBSD.org>
Subject: Re: svn commit: r250972 - head/usr.bin/patch
Message-ID: <20130526215125.GC1381@garage.freebsd.pl>
References: <201305241854.r4OIsqdU043683@svn.freebsd.org>
 <20130525051127.GP1756@glenbarber.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="7gGkHNMELEOhSGF6"
Content-Disposition: inline
In-Reply-To: <20130525051127.GP1756@glenbarber.us>
X-OS: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 Stefan Esser <se@FreeBSD.org>, src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 26 May 2013 21:48:41 -0000


--7gGkHNMELEOhSGF6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, May 25, 2013 at 01:11:27AM -0400, Glen Barber wrote:
> On Fri, May 24, 2013 at 06:54:52PM +0000, Stefan Esser wrote:
> > Author: se
> > Date: Fri May 24 18:54:52 2013
> > New Revision: 250972
> > URL: http://svnweb.freebsd.org/changeset/base/250972
> >=20
>=20
> > [...]
>=20
> > @@ -977,7 +977,7 @@ spew_output(void)
> >  #endif
> >  	if (input_lines)
> >  		copy_till(input_lines, true);	/* dump remainder of file */
> > -	rv =3D ferror(ofp) =3D=3D 0 && fclose(ofp) =3D=3D 0;
> > +	rv =3D ferror(ofp) =3D=3D 0 & fclose(ofp) =3D=3D 0;
> >  	ofp =3D NULL;
> >  	return rv;
> >  }
> >=20
>=20
> This breaks head/.

Not to mention that it is really ugly and without any comment it looks
like a typo.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://mobter.com

--7gGkHNMELEOhSGF6
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (FreeBSD)

iEYEARECAAYFAlGig90ACgkQForvXbEpPzRpnQCfd2ouzLBvqchMOT3sZ5z4iGbq
INsAn0KWj1LFfJkqLSW2bdrmAC1SeHdl
=etOR
-----END PGP SIGNATURE-----

--7gGkHNMELEOhSGF6--