From nobody Fri Dec 26 15:43:50 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dd8zV5B8vz6LmFf for ; Fri, 26 Dec 2025 15:43:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dd8zV2M7yz431V for ; Fri, 26 Dec 2025 15:43:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766763830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sXVYgf5dbL/1UwgZ9c75mHyrkYMzDbD/UTkoTqL19To=; b=sEBcXZSJJ/e3YouD9hu+pfdjAhF3bOcSvsYUXgHmjhSYF5Ml5pu7t2Q7XvBaJ3eePYX2wZ oRcePmYhk7bJMXJKT+MuO5XJoxYJlpxdmM4St/Ly3JZ4hnH5jppIQ56ygvTvDlzMgVrDfn /ddM0lOnqQFLybrNFa+CTAmqXEhXMd1RLMhCWCPea2UwU4QVjZAipMAYK2VvJhj9wRzbES 3XqhwYF7TO2BOQhaf6o0VjGQUwprm0VLeQ7FgtuB1Brx/NEKyL3YQdGMsyIfvhqYMpNk1q pkh4v987ff7T6YlHvqcIPMOx1x5J2r58+GMwEP1EosuslSWiyzlNRohQgJ8zOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766763830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sXVYgf5dbL/1UwgZ9c75mHyrkYMzDbD/UTkoTqL19To=; b=geY9bkKH3WNXu+0CIqp+Lo/nQSFqvPnmfGaAvuApp9FVz7kFW1GQjJvzQvCxRAOJQeiF+f IJlFshpD4nsuqi0Y7XILirFMvVKeSco+ZRWZ2o7edk1GAA592n9lno6gLl5VCGdHM0ha6K SBwIgZwM1cMHe9NaTc1qrNiHmGVFruEMpnUkOWAuz/EWkdbGSEunuPG116/LhN2YnQq0k1 KgrJhl49tQJA5j5q3ic0OUTHqTIjsNlm674kTElaRuUnFOMrCKx+BFakPMHGfqmrkKD/1X XpB/5X+d3lV5sMAB0SMkL+kEEOQfMbESp2q/t2T7lMdBAUHyeQc8MaGpe8s/iA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1766763830; a=rsa-sha256; cv=none; b=KOj5aYEKdrn9kHk9o1KsnRYcDTcmYE/aUPSQ7jjgA9RVxdipV8b9sQ+HLIw6kfZ8yL9yNk nwCIGQ+HkG5hkU/rJWCKsYsDI/sJhFMMP4KGZdJ9mUhrBIziX/PKTJp26v2jh4QQOOxWFG vD4L4SSu9C+QqyXqU6pWaV07wYJpg3ewLZI0TmQzXIB25gXByDt3ZUXxNDGe3oI7ibT+vO 1BWjnjeDERMVBOMHR++sAGd/tV78/3+D5e9b/pGKfD7n/DN5f7xX3Catcc+lxhYC7d85Cl APpiM18dJG51RLCMfUONmJ1UnGfEjqIrBYyjSgqNE/4KpDXwgzUffQU2tzBLOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dd8zV1vRQz43K for ; Fri, 26 Dec 2025 15:43:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id d568 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 26 Dec 2025 15:43:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 88f8e3c5ab97 - main - acpi_apei: Remove the hest member from the softc List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 88f8e3c5ab97025587d7df761c8ae72e2db6c1d3 Auto-Submitted: auto-generated Date: Fri, 26 Dec 2025 15:43:50 +0000 Message-Id: <694ead36.d568.4445eb6d@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=88f8e3c5ab97025587d7df761c8ae72e2db6c1d3 commit 88f8e3c5ab97025587d7df761c8ae72e2db6c1d3 Author: John Baldwin AuthorDate: 2025-12-26 15:36:24 +0000 Commit: John Baldwin CommitDate: 2025-12-26 15:36:24 +0000 acpi_apei: Remove the hest member from the softc This is only used during attach and freed after use, so just use a local variable in the attach routine instead to avoid leaving a dangling pointer around in the softc. Reviewed by: imp Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D54310 --- sys/dev/acpica/acpi_apei.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/sys/dev/acpica/acpi_apei.c b/sys/dev/acpica/acpi_apei.c index 0d23b504cb60..e85b3910e46d 100644 --- a/sys/dev/acpica/acpi_apei.c +++ b/sys/dev/acpica/acpi_apei.c @@ -86,7 +86,6 @@ struct apei_pges { }; struct apei_softc { - ACPI_TABLE_HEST *hest; TAILQ_HEAD(, apei_ge) ges; struct apei_nges nges; struct apei_iges iges; @@ -562,9 +561,8 @@ hest_parse_structure(struct apei_softc *sc, void *addr, int remaining) } static void -hest_parse_table(struct apei_softc *sc) +hest_parse_table(ACPI_TABLE_HEST *hest, struct apei_softc *sc) { - ACPI_TABLE_HEST *hest = sc->hest; char *cp; int remaining, consumed; @@ -662,6 +660,7 @@ static int apei_attach(device_t dev) { struct apei_softc *sc = device_get_softc(dev); + ACPI_TABLE_HEADER *hest; struct acpi_softc *acpi_sc; struct apei_pges *pges; struct apei_ge *ge; @@ -691,11 +690,11 @@ apei_attach(device_t dev) } /* Search and parse HEST table. */ - status = AcpiGetTable(ACPI_SIG_HEST, 0, (ACPI_TABLE_HEADER **)&sc->hest); + status = AcpiGetTable(ACPI_SIG_HEST, 0, &hest); if (ACPI_FAILURE(status)) return (ENXIO); - hest_parse_table(sc); - AcpiPutTable((ACPI_TABLE_HEADER *)sc->hest); + hest_parse_table((ACPI_TABLE_HEST *)hest, sc); + AcpiPutTable(hest); rid = 0; TAILQ_FOREACH(ge, &sc->ges, link) {