From owner-p4-projects@FreeBSD.ORG  Thu Dec  4 20:36:04 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7EAB0106567D; Thu,  4 Dec 2008 20:36:04 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1827B1065676
	for <perforce@FreeBSD.org>; Thu,  4 Dec 2008 20:36:04 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 079008FC1E
	for <perforce@FreeBSD.org>; Thu,  4 Dec 2008 20:36:04 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mB4Ka34Y024552
	for <perforce@FreeBSD.org>; Thu, 4 Dec 2008 20:36:03 GMT
	(envelope-from ed@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mB4Ka328024550
	for perforce@freebsd.org; Thu, 4 Dec 2008 20:36:03 GMT
	(envelope-from ed@FreeBSD.org)
Date: Thu, 4 Dec 2008 20:36:03 GMT
Message-Id: <200812042036.mB4Ka328024550@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	ed@FreeBSD.org using -f
From: Ed Schouten <ed@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 154071 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Dec 2008 20:36:04 -0000

http://perforce.freebsd.org/chv.cgi?CH=154071

Change 154071 by ed@ed_flippo on 2008/12/04 20:35:20

	Hummm... It seems the problem is a little more complex.
	
	We should not need to call mark_for_update() (reading the source
	code), but for some reason this causes the input not to be
	drawn.
	
	If we call mark_for_update(scp, cursor + 1), we get a
	spontaneous reboot later on, because scp->end is out of bounds
	then. Temporary hack: call mark_for_update(scp, cursor + 1)
	unless we're at the last cell on the display.

Affected files ...

.. //depot/projects/mpsafetty/sys/dev/syscons/scterm-teken.c#7 edit

Differences ...

==== //depot/projects/mpsafetty/sys/dev/syscons/scterm-teken.c#7 (text+ko) ====

@@ -273,7 +273,8 @@
 	p = sc_vtb_pointer(&scp->vtb, cursor);
 	sc_vtb_putchar(&scp->vtb, p, map[ch], scteken_attr(a));
 	mark_for_update(scp, cursor);
-	mark_for_update(scp, cursor + 1);
+	/* XXX: why? */
+	mark_for_update(scp, imin(cursor + 1, scp->xsize * scp->ysize - 1));
 }
 
 static void