From owner-freebsd-bugs@FreeBSD.ORG  Tue Jan 25 14:50:08 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8A013106566C
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 25 Jan 2011 14:50:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 441FC8FC14
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 25 Jan 2011 14:50:08 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0PEo8bk095877
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 25 Jan 2011 14:50:08 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0PEo81W095876;
	Tue, 25 Jan 2011 14:50:08 GMT (envelope-from gnats)
Resent-Date: Tue, 25 Jan 2011 14:50:08 GMT
Resent-Message-Id: <201101251450.p0PEo81W095876@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Sebastian Huber <sebastian.huber@embedded-brains.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EA6B6106566B
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 25 Jan 2011 14:47:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id D98E08FC24
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 25 Jan 2011 14:47:54 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p0PEls1o073902
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 25 Jan 2011 14:47:54 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p0PElsSf073901;
	Tue, 25 Jan 2011 14:47:54 GMT (envelope-from nobody)
Message-Id: <201101251447.p0PElsSf073901@red.freebsd.org>
Date: Tue, 25 Jan 2011 14:47:54 GMT
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/154287: Avoid malloc(0) implementation dependency in
	device_get_children()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jan 2011 14:50:08 -0000


>Number:         154287
>Category:       kern
>Synopsis:       Avoid malloc(0) implementation dependency in device_get_children()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 25 14:50:07 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Sebastian Huber
>Release:        9-current
>Organization:
embedded brains GmbH
>Environment:
>Description:
The device_get_children() implementation of the device(9) API depends on a particular malloc(0) behavior.  This makes it less portable to other operating systems.  The following patch avoids a malloc(0).
>How-To-Repeat:

>Fix:
Index: kern/subr_bus.c
===================================================================
--- kern/subr_bus.c     (revision 216297)
+++ kern/subr_bus.c     (working copy)
@@ -2090,14 +2090,19 @@
                count++;
        }
 
-       list = malloc(count * sizeof(device_t), M_TEMP, M_NOWAIT|M_ZERO);
-       if (!list)
-               return (ENOMEM);
+       if (count) {
+               list = malloc(count * sizeof(device_t), M_TEMP,
+                   M_NOWAIT|M_ZERO);
+               if (!list)
+                       return (ENOMEM);
 
-       count = 0;
-       TAILQ_FOREACH(child, &dev->children, link) {
-               list[count] = child;
-               count++;
+               count = 0;
+               TAILQ_FOREACH(child, &dev->children, link) {
+                       list[count] = child;
+                       count++;
+               }
+       } else {
+               list = NULL;
        }
 
        *devlistp = list;

>Release-Note:
>Audit-Trail:
>Unformatted: