From owner-svn-src-projects@freebsd.org Tue Sep 3 14:06:08 2019 Return-Path: Delivered-To: svn-src-projects@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB032DC32C for ; Tue, 3 Sep 2019 14:06:05 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7z108qhz4P9w; Tue, 3 Sep 2019 14:06:05 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 6C4A61A0D3; Tue, 3 Sep 2019 14:05:57 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 6BA2F7181; Tue, 2 Apr 2019 18:51:07 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2C4BD7222B; Tue, 2 Apr 2019 18:51:07 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 150877180; Tue, 2 Apr 2019 18:51:07 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 459307176; Tue, 2 Apr 2019 18:51:04 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9B5AE721BF; Tue, 2 Apr 2019 18:51:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x62f.google.com with SMTP id w24so318072plp.2; Tue, 02 Apr 2019 11:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0r3dyu4gPQV/0ZI5C2ryoJAfgk5K3GaxT3DbTuAWh5c=; b=bmLlftprRtxnieWqX6lwAEaqvW9/n883LH6m8LCUT+oNTTXUuzclcHznVpjOjhcg88 UDBkV2L1hKNWfzxUdm38kO8oxR5rizYWvu8CLaPvZlI4qc/LVj7RMTQESEXrR/9UteZt TF9yptGxqOpbdlfBLWtQfrremGbdpGRXG3FZOV0UB+HijmPqseQxVODfX6p901U7TXpH XYT+XbHvtbhFcWjTeQb4oOznvVvJbNh6J+9Usr3n68T5TIOljiVuRYoSmBDhuXJ3bIjF lLEXWF7aVRTXh/PV8w6aK9Ur1WpWgilfx46TxvfeKiRleB0lKjA33Qs+6h6dQO4Ewsoa t+hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0r3dyu4gPQV/0ZI5C2ryoJAfgk5K3GaxT3DbTuAWh5c=; b=c+ISgUrnkv2lPSO+D6evKa6h50kfRhdF84fYklmwtEhfpRZL5Yb4tAUHolQ/R+RR3U UWk9Q1QNpsQ2duDGHjiZ1Kn/6khoCdG2TR+ppdmbZ2B6PRbftadGQ/yxaxnN5F0tx7PZ nN5iTy0Jo6bWVAcxHTDkStzHSvHVdd+q08+avMXbZDoVj/5blmoh9ywDPWnzxNJr/BY6 +kW6SOK9i1AIZMaZSnvZtBgrxNkcG2Czx5t7sIxKT6EgKg8nbo1SWP4CdqgILxp3sbP0 ZED0XCwNjXhLbaxqSb1zbZAjZsRcSIWMTmIfa/HUYD28RVXMJsqTYk739nBxN4RDtwAl 6tzw== X-Gm-Message-State: APjAAAVbSP/zeYMtORn0w2qnhZUDP064yCPdso6HiQIQZpBpaqD/Demj lGId5QyNuriZ2tiQeILs9CeCuenpwAw= X-Google-Smtp-Source: APXvYqwPVafnRVtPwk9aTb12GQHLqaPYAhgKidrvmlQQoUhm4wUqChYCp+9ixsMZdo9NiYGa+ucTIQ== X-Received: by 2002:a17:902:f089:: with SMTP id go9mr31826442plb.309.1554231058364; Tue, 02 Apr 2019 11:50:58 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id t64sm33852261pfa.86.2019.04.02.11.50.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Apr 2019 11:50:57 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r345809 - projects/fuse2/tests/sys/fs/fusefs From: Enji Cooper In-Reply-To: Cc: src-committers , svn-src-projects@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <1590D5B3-58F2-4086-8717-804AB5F89B69@gmail.com> References: <201904021844.x32Ii1wR041319@repo.freebsd.org> <77D06D49-8CE8-483C-90FF-D8CD0122599E@gmail.com> To: Alan Somers X-Mailer: Apple Mail (2.3445.102.3) Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 2C4BD7222B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:06:09 -0000 X-Original-Date: Tue, 2 Apr 2019 11:50:56 -0700 X-List-Received-Date: Tue, 03 Sep 2019 14:06:09 -0000 > On Apr 2, 2019, at 11:49 AM, Alan Somers wrote: >=20 > On Tue, Apr 2, 2019 at 12:45 PM Enji Cooper = wrote: >>=20 >>=20 >>> On Apr 2, 2019, at 11:44 AM, Alan Somers = wrote: >>>=20 >>> Author: asomers >>> Date: Tue Apr 2 18:44:01 2019 >>> New Revision: 345809 >>> URL: https://svnweb.freebsd.org/changeset/base/345809 >>>=20 >>> Log: >>> fusefs: check return value of wait(2) in fork tests >>>=20 >>> Reported by: ngie >>> Sponsored by: The FreeBSD Foundation >>>=20 >>> Modified: >>> projects/fuse2/tests/sys/fs/fusefs/utils.cc >>>=20 >>> Modified: projects/fuse2/tests/sys/fs/fusefs/utils.cc >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- projects/fuse2/tests/sys/fs/fusefs/utils.cc Tue Apr 2 = 18:09:40 2019 (r345808) >>> +++ projects/fuse2/tests/sys/fs/fusefs/utils.cc Tue Apr 2 = 18:44:01 2019 (r345809) >>> @@ -321,7 +321,7 @@ out: >>> /* Signal the child process to go */ >>> ASSERT_EQ(0, sem_post(sem)) << strerror(errno); >>>=20 >>> - wait(&child_status); >>> + ASSERT_LE(0, wait(&child_status)) << strerror(errno); >>=20 >> Don=E2=80=99t you want ASSERT_GE here, since you=E2=80=99re testing = that wait succeeded? >> -Enji >=20 > Opposite operand order. I'm asserting that 0 is less than or equal to > wait's return value. Ah, yes. Derp. Thank you for correcting me on that :D. -Enji