From owner-freebsd-ports@freebsd.org Tue Sep 26 04:53:57 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 002C6E2ED74; Tue, 26 Sep 2017 04:53:56 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: from mail-wr0-x231.google.com (mail-wr0-x231.google.com [IPv6:2a00:1450:400c:c0c::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 94F5E76195; Tue, 26 Sep 2017 04:53:56 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: by mail-wr0-x231.google.com with SMTP id g29so11308673wrg.11; Mon, 25 Sep 2017 21:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9Ti33L1XY1RwpQT9Ha+pBM6J2R5kw/9wxyKqbw3vcLs=; b=t9MHsQl4pSEXjQklBhvcwlqF3iB4tm1pWJapBn/6G7t0iyybfFUvmrfVzyOcvV4+MY tkTbg3H3O7GZnQtJNNDMkSOd985CEvpnm71Fw+7lU5Kdq4Sl+h48Qe3IGB1clUKXMgsl 2aCA6RgfgU79vUxwMgsyg9W2yTZPltr1i64BfmnGLiudkgFVmZrUhSBLOnKUtIOASyDN p2Lkg7kbmDy2aYG1Lpxt5Q7j949qiCYkyk2AOx1Nt4XdDIGxagDb2Mlqxqo7UW8SYd+l l30gobRv8cuAW6lFZ4iEaKt3x0JRXoSbfvq9HFDhgg1elvHo5DY+EMCg0eT7X2sLAtW2 ouQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9Ti33L1XY1RwpQT9Ha+pBM6J2R5kw/9wxyKqbw3vcLs=; b=DHqWkSmGvwzREqO/khPKJEI65xt+/dwhvhk4ggfiRiTS98GHA0CaUJLN5NqVsJbLwj /+D9Sbi2d2pPqJ5P0y47EbB6EMLo6J2HB3hoiUT6QCL1TiiZyqBncFcs30ofyS3GEhKk JUdvZhmHuO695PkFWAjG5VcQHDD5k5qwtOcP7cUeP8+4J9bECF57tIUuy53/R/RqiS8L zKt7DLL2/e7f+KPxGa/qIveOpzSLfqJQm2KywBGF216cugxykeFEtQWzH6vmVa/vO2z4 6jeTaBRyfU8cBB189QTBWk2egvb7RCLnOY0wzUG9IfKmCfgAavNg8uZ3QXYEAp5IxIfM m6kg== X-Gm-Message-State: AHPjjUjs1XMdN/FGmeJje3Fl2NewxyKQw8jdGB1TrloRb6SqMGLFKvh9 WlGsGQ6D8GJ/5OoVCjFgDQFBVzxu0GsPod/GU08xbw== X-Google-Smtp-Source: AOwi7QCg7DOT/B9t+ghHsCyoBnJTjd6dj4HOTsre3vIYmiomLiLgZYtr8sJU6yajUCp7+h3ukx+/MsBhPO4AVQ/lKpc= X-Received: by 10.46.101.24 with SMTP id z24mr3671803ljb.42.1506401634860; Mon, 25 Sep 2017 21:53:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.81.65 with HTTP; Mon, 25 Sep 2017 21:53:54 -0700 (PDT) In-Reply-To: <8a3e663a-d94f-0ef7-bbc7-8ebaa111f6dd@FreeBSD.org> References: <8a3e663a-d94f-0ef7-bbc7-8ebaa111f6dd@FreeBSD.org> From: Russell Haley Date: Mon, 25 Sep 2017 21:53:54 -0700 Message-ID: Subject: Re: Porters Handbook section 4.4 To: koobs@freebsd.org Cc: freebsd-ports@freebsd.org, doc@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2017 04:53:57 -0000 On Sun, Sep 24, 2017 at 10:02 PM, Kubilay Kocak wrote: > On 9/25/17 2:08 PM, Russell Haley wrote: >> Hi, >> >> Section 4.3 of the porters handbook talks about making modifications >> to a private copy of a tarball and recording the steps. >> >> Section 4.4 talks about changing directories into the affected ports >> dir and running make makepatch to generate patch files. >> >> I am unsure how the makepatch target is supposed to find my private >> directory. Since I was confused, I created patches, added them to the >> port, ran make, then ran make makepatch and the system re-generated >> new "makepatch" patches. > > Quite a number of new users have raised the same question on IRC. > >> So, my question is thus: >> >> To me, section 4.4 seems vague about where changes should be made, >> which is compounded by the information in section 4.3. Can the >> makepatch target ask for and find a private directory, or should the >> handbook be clarified to state that the changes should be made to the >> 'work' folder? If the later is true, I assume there is some proper >> workflow to keep changes from being destroyed while testing? > > The handbook section needs to be updated to be less ambiguous with > regard to where things should be done. > > I'd be happy to provide a docs committer with verbiage if they can help > with formatting/commit. Hi, If you provide the verbiage, I'll attempt a patch. :) Russ >> If there is a section in the handbook clarifying this, please just say >> so and I will go find it. >> >> Thanks! >> Russ > > ./koobs