From owner-freebsd-current@FreeBSD.ORG  Tue Aug 24 07:33:47 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A1CFB16A4CE
	for <current@freebsd.org>; Tue, 24 Aug 2004 07:33:47 +0000 (GMT)
Received: from pandora.afflictions.org (asylum.afflictions.org [64.7.134.90])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7631743D55
	for <current@freebsd.org>; Tue, 24 Aug 2004 07:33:46 +0000 (GMT)
	(envelope-from dgerow@afflictions.org)
Received: from localhost (localhost [127.0.0.1])
	by pandora.afflictions.org (Postfix) with ESMTP id E291478C8D
	for <current@freebsd.org>; Tue, 24 Aug 2004 03:38:39 -0400 (EDT)
Received: from dementia.afflictions.org (dementia.afflictions.org
	[172.19.206.56])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by pandora.afflictions.org (Postfix) with ESMTP id 0C66C78C8C
	for <current@freebsd.org>; Tue, 24 Aug 2004 03:38:31 -0400 (EDT)
Received: by dementia.afflictions.org (Postfix, from userid 1001)
	id 157001700B; Tue, 24 Aug 2004 03:33:56 -0400 (EDT)
Date: Tue, 24 Aug 2004 03:33:56 -0400
From: Damian Gerow <dgerow@afflictions.org>
To: current@freebsd.org
Message-ID: <20040824073356.GK25125@afflictions.org>
Mail-Followup-To: current@freebsd.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Operating-System: FreeBSD 5.2-CURRENT on a i386
X-GPG-Fingerprint: B3D7 D901 A53A 1A99 BFD6  E6DF 9F3B 742B C288 9CC9
User-Agent: Mutt/1.5.6i
X-Virus-Scanned: by amavisd-new at afflictions.org
Subject: RELENG_5 build broken with BKTR_USE_FREEBSD_SMBUS and
	BKTR_NEW_MSP34XX_DRIVER enabled
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Aug 2004 07:33:47 -0000

In trying to build a kernel with bktr support, I'm using both
BKTR_USE_FREEBSD_SMBUS and BKTR_NEW_MSP34XX_DRIVER.  This is what I see on a
compile:

    cc -c -O -pipe -march=pentium4 -Wall -Wredundant-decls -Wnested-externs \
      -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline \
      -Wcast-qual  -fformat-extensions -std=c99  -nostdinc -I-  -I. \
      -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica \
      -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter \
      -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath \
      -I/usr/src/sys/contrib/dev/ath/freebsd \
      -I/usr/src/sys/contrib/ngatm -D_KERNEL -include opt_global.h \
      -fno-common -finline-limit=8000 --param inline-unit-growth=100 \
      --param large-function-growth=1000  -mno-align-long-strings \
      -mpreferred-stack-boundary=2 -ffreestanding -Werror  \
      /usr/src/sys/dev/bktr/msp34xx.c
    In file included from /usr/src/sys/dev/bktr/msp34xx.c:92:
    /usr/src/sys/dev/bktr/bktr_reg.h:451: error: syntax error before "device_t"
    *** Error code 1

    Stop in /usr/obj/usr/src/sys/dementia.
    *** Error code 1

    Stop in /usr/src.
    *** Error code 1

    Stop in /usr/src.

Removing either option fixes the build.  The only thing in NOTES that might
address this is the note saying bktr has been ported to the new I2C
framework.  Is this an obvious don't-do-that?