From owner-svn-src-head@freebsd.org Sun Jul 26 08:41:38 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A83C9A3C1A; Sun, 26 Jul 2015 08:41:38 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BC28493F; Sun, 26 Jul 2015 08:41:37 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t6Q8fW6s081941 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sun, 26 Jul 2015 11:41:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t6Q8fW6s081941 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id t6Q8fWsQ081940; Sun, 26 Jul 2015 11:41:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 26 Jul 2015 11:41:32 +0300 From: Konstantin Belousov To: Christian Brueffer Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285885 - head/sys/fs/tmpfs Message-ID: <20150726084132.GM2072@kib.kiev.ua> References: <201507260833.t6Q8Xlb1023371@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201507260833.t6Q8Xlb1023371@repo.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2015 08:41:38 -0000 On Sun, Jul 26, 2015 at 08:33:47AM +0000, Christian Brueffer wrote: > Author: brueffer > Date: Sun Jul 26 08:33:46 2015 > New Revision: 285885 > URL: https://svnweb.freebsd.org/changeset/base/285885 > > Log: > In tmpfs_chtimes(), remove checks on the nanosecond level when > determining whether a node changed. No, these are checks to see if the userspace requested an update to the corresponding inode time and supplied valid time. I.e. the code change is right, but the commit message is misleading. > > Other filesystems, e.g., UFS, only check on seconds, when determining > whether something changed. > > This also corrects the birthtime case, where we checked tv_nsec > twice, instead of tv_sec and tv_nsec (PR). > > PR: 201284 > Submitted by: David Binderman > Patch suggested by: kib > Reviewed by: kib > MFC after: 2 weeks > Committed from: Essen FreeBSD Hackathon > > Modified: > head/sys/fs/tmpfs/tmpfs_subr.c > > Modified: head/sys/fs/tmpfs/tmpfs_subr.c > ============================================================================== > --- head/sys/fs/tmpfs/tmpfs_subr.c Sun Jul 26 00:11:04 2015 (r285884) > +++ head/sys/fs/tmpfs/tmpfs_subr.c Sun Jul 26 08:33:46 2015 (r285885) > @@ -1709,20 +1709,18 @@ tmpfs_chtimes(struct vnode *vp, struct v > if (error != 0) > return (error); > > - if (vap->va_atime.tv_sec != VNOVAL && vap->va_atime.tv_nsec != VNOVAL) > + if (vap->va_atime.tv_sec != VNOVAL) > node->tn_status |= TMPFS_NODE_ACCESSED; > > - if (vap->va_mtime.tv_sec != VNOVAL && vap->va_mtime.tv_nsec != VNOVAL) > + if (vap->va_mtime.tv_sec != VNOVAL) > node->tn_status |= TMPFS_NODE_MODIFIED; > > - if (vap->va_birthtime.tv_nsec != VNOVAL && > - vap->va_birthtime.tv_nsec != VNOVAL) > + if (vap->va_birthtime.tv_sec != VNOVAL) > node->tn_status |= TMPFS_NODE_MODIFIED; > > tmpfs_itimes(vp, &vap->va_atime, &vap->va_mtime); > > - if (vap->va_birthtime.tv_nsec != VNOVAL && > - vap->va_birthtime.tv_nsec != VNOVAL) > + if (vap->va_birthtime.tv_sec != VNOVAL) > node->tn_birthtime = vap->va_birthtime; > MPASS(VOP_ISLOCKED(vp)); >