From nobody Thu Jan 29 17:09:36 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f25H30s7Wz6R17N for ; Thu, 29 Jan 2026 17:09:51 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic311-24.consmr.mail.gq1.yahoo.com (sonic311-24.consmr.mail.gq1.yahoo.com [98.137.65.205]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4f25H23zrCz3MVD for ; Thu, 29 Jan 2026 17:09:50 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1769706583; bh=zXVLjQitDQOT1Sz+9v4hHZ30n3IBQQwnJh+hQd4nTBs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=eyQ++AIZN0AxgmBtsc97ulnwSZ8zAVXsontTEgJXD1WgM4qNdB3O7/IKxfcLuZ2Y+NxPS2Nx61T77pgdEudQk+L7186XCYreaL9gr7NjH/KmpLG0l1PRZThlh3blvK3lwVdsdGSmaeR04IJO9/LCPJhCa35HmztWFcLhMe/W+TVj8QoqD7oo1bk+ubRuQnPowZPaiO+g051thTuDVoDcDFS5KL53YbZk9VVpKYR9dOUEFlSzeLUDwcMF/NZqLNfJcte2JfC1eMcaRlSDYiJg0XPIJjOuMe8Wj9kzf5WSVA8NvwSemAiAoKiEIggIIikC1Re/RrkGabqjpai6ipxlRw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1769706583; bh=JWTpJnhIWKflKKhvwKu3VySioDH56SP1h+Gr2zwLgAG=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=JKZzEwdetlfmPrJnok01Ry3bYQYtav0R/DxUbSg50edx+j3OQJloCgWuSjvWOWIEibVn5CyQ7ocuuuy3WeBhjjr8nfEcrXYYvVS4pox+9rwPnNeFgaMNlu9sDy4mBdU3r+iOdzuWNMx6j68N99XGyPQiGudFHLXLqj65i2o5RSUW5UnH3/75khI1FtIUzsMgLKDhI5fQBqsvSnX0FRBdkVhDLqUVthDbjJkSeY7lxyEMIfC/3Cj7ukntAEYY7/8EF9uibVmTMaojo0B82EXydFxi88OeWoQvdExfRoTW1HJmZoB+HNCmqLqHONMFtmMeMxe7jSY5+xu3PZ8wRlq3MQ== X-YMail-OSG: Og85wZsVM1n_yIPeXnJGeyf1paySb.7P2t5bj1tvZwlEDeW1i.IynoM2UYHuXUw qRKVuUfc69O1Mwrc5H9cHbrqF4zf1gYvjmQvFrw7Ec9z_CnxcbNdh1Bqz8lTCGd.VabjEXqjuFcj yuOloZdGseuKFexWtI6AO7uWJ.kqyjm5ghHHM8bv9UNmG7sLX7L_jMhGONA5M0Gws1an4kBq.KV4 IDe544rX3tPFgN2xiTaSI9z2hvY_NEbQdzsItyQ_Tm35sG2.1ZWVgB74q.RLMARbCNu_vWJlaNS4 LQBhYl6w8oBv2Lzf8H.tabeDMKo6OuS.rd9Ivt1ZWrvllXAZhOJ09Lm.kbEy3WN6rjFfotjnndCU sIsYmBRhxBVZWlt5XG33y7LsdcrE4BJ.oUUn_uX8Fh8YRgPglyxdhSzcr43WKSS1HHaosFsPZ9Z0 p2pl04XStgOReYfhoBvrQrIVRn62MJKoIY5FArbMpkT0yT7f17aQ20ChgSCV5qUeo2yNF5f8iMNc Ls56TCsREdEhwwMuc7ZnaEgOoX9MC0f5OPHcYZQyIT7WU9KPlW980vNBjkktTTxtApYuZ4zKJNty jYcUZTUsw2CSXcpEW8Su8RksASIAbcx8K6xgI8FuGJL3g8cUE8gOkAGbo1RUhfq87bCLjJKDLOXE aqgm_Vl_RSlz95HXagK48lRiGFLoK_Q_7m2zhZFiomXMfEojsdRyg7XC3IhbS27d8wVbB77n0r_B l5_MFBHRM4wl0pi39P0O3koqMT1MBb5RnG6SfhKTYBUHKAJdLN0pEGIHRkXyPoHfZZ3hP4vArK1N Z6g9J2nFoynHexiqciMO1d5voRVGmphF07q7u7fNOKGas6WHxuMcFeFyBJ5M0WKO1AfROQyXqvld 6KvJSoRzL1NYCfvzsy8xCL.IV6pXE3d7.0tfDlFLpfzRjw6IaGf8okehvukf_tkLRLlszC8pREWd tkw_XmzXE3jNwGXEAH2nivkt123xAZTq1hRSpLmh4vVMalfUQAeN5ZOCK5y7mB1fMyOz3JFumsuF JuE69e_33h0Vjn8fsHVptDA3Jy7UzA6hoFj4tN5WN.TMbp6Ux7tpTGcjEAtk.Tou23GBdomkVDJL OSUjZnCJ_WEzfXIAAqEGPkMDuOlWAt7HklSeZqFH98EPcxqUKnwmO_OG7ADPc4BPyghymELfQ.oL 8dJMYvsYIYUe7ruvfrqP_pJWoG9UcIiLW249ysnLIiHAPzPzAIYlBiNtviHiLcy11RhK2mWXtWs6 lrqTpQevWFlvHv5QzguSN2m10HsPTM3QxrJ.k7xfPkTxnKlmeS7OC6kfq3ZQ665xocpijQSUf_0F 1zVmRfseLZhQIgr_ukJe2gkev39r_l2YLtoWBVnvdsdNeeIrBN05kcfQJELJ5IifyKQ.gAtHjZiZ yFyfTFJv9pao185F5ZIP7f79zLxJrzE3U7cUtZ3OZoy69xmKFNfRssbUhfSQ8U87skPXmv8Q9k9G JEEkWhQe6KYyWN0ZdngUFWc2Nic1qWnMwr3siMU_Rm0ZACi5Dsu5zKPXBJYQm8o9dma8wtMj7Rpf P9IdP9jaRGZHoWridPpzKW70qjGlY.WZo_pcVL4QJPmm1dnnuN2pA3PAk7PlPJixTvaGDnhOR0aS yHplkveBX1JEKt7ab1Ro2uKF2SpQ1IiMCdZ9W_HYFXO1GjQtz63FVraQyVICKutAZ35_KwFtBduP vwZ0lbRifL1Dlz_SOiC9KqLA7elOa_Lfjt8nelJ01j4dtWMC8x.qU4yrhLFWg_h5iVELRcmOcuzD Ezwfb5nBS6Wz25mozsDIPowbnlq.AGu1KMg5ZQeB3c4aYv1TIDDH0IbJ2grMDZRvvqGhmHZcs5IS jG6Ty7yn..DtadnrQVshiJ7mS.i0XI1clUAXZPsck3ulB0vAvxt7c._RhHZhikZQsfSAHjF9s2wr wktJp3xeNI9gTZ1p79IgWpYHPj8aa4ah_RvI8V9T7fNfJyqDkuM.HM18ft0SVZ0xqL71X2yLfQ1g 0A7ReTy3gel7Jnoj.DN36jrBfJmJTeJhMaZBRnE_mHJx32ff5r6n_Pf2Tmun1KrvCKA456TjHBfc .BGPaf99Moa4NY9Vng199t3k95xBNd_lK42EpO0ntdeCEKziuUijxeHsTFESjCOzygX4OJjI8bGb dOqz3uIHEDjY948NZdtFL51X1KWylLvXRUd_CVOr_TJcG2NlN8sr2iNF0zJkKF3eAdGgA6LbEbK3 MqG3OaxLanIJjRXv6EcJJrDh3xCVZVEzJKEt8gcbRvqFm57Nx0nM7s3Z.LoY3jWek24hkiojQM4M DwC2KkZdlm61l9KhgGZZZzEfzLxxQrR0geXQu8xPMqTGW1sxFfw-- X-Sonic-MF: X-Sonic-ID: b19e011d-36b4-436c-8379-adfc254aa5e0 Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.gq1.yahoo.com with HTTP; Thu, 29 Jan 2026 17:09:43 +0000 Received: by hermes--production-gq1-86969b76cd-n48h7 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3a505aa9e763b312140aac5d2f1713af; Thu, 29 Jan 2026 17:09:37 +0000 (UTC) Message-ID: <1ecdc41d-6d16-45e1-9e32-dade86348d16@yahoo.com> Date: Thu, 29 Jan 2026 09:09:36 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 56970c3c4b0b - main - loader: Prefer comma-separated list of values for "console" To: Michael Osipov , freebsd-stable@freebsd.org Cc: Warner Losh , dev-commits-src-main@FreeBSD.org References: <697b1e0e.27b69.ae3352c@gitrepo.freebsd.org> <40a3f9a2-3adc-470b-8dcb-63b166e2cf14@FreeBSD.org> Content-Language: en-US From: Mark Millard In-Reply-To: <40a3f9a2-3adc-470b-8dcb-63b166e2cf14@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.24987 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Rspamd-Queue-Id: 4f25H23zrCz3MVD X-Spamd-Bar: ---- On 1/29/26 08:31, Michael Osipov wrote: > On 2026-01-29 17:22, Mark Millard wrote: >> On 1/29/26 00:45, Michael Osipov wrote: >>> The branch main has been updated by michaelo: >>> >>> URL: https://deu01.safelinks.protection.outlook.com/? >>> url=https%3A%2F%2Fcgit.freebsd.org%2Fsrc%2Fcommit%2F%3Fid%3D56970c3c4b0bc61d972837661a31cc2b9e8e8d7c&data=05%7C02%7Cmichael.osipov%40innomotics.com%7C599792c98cac445815a108de5f529e81%7C698c6ffb74e34a84be68f22d8d3201a3%7C0%7C0%7C639053005625974477%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=PsvT9MHa5qWyE2CBQGLbDG30GT8AWpltNOu3JrYO%2BK4%3D&reserved=0 >>> >>> commit 56970c3c4b0bc61d972837661a31cc2b9e8e8d7c >>> Author:     Michael Osipov >>> AuthorDate: 2026-01-28 09:02:33 +0000 >>> Commit:     Michael Osipov >>> CommitDate: 2026-01-29 08:44:45 +0000 >>> >>>      loader: Prefer comma-separated list of values for "console" >>>           PR:             292595 >>>      Reviewed by:    imp >>>      MFC after:      1 week >>>      Differential Revision:  https:// >>> deu01.safelinks.protection.outlook.com/? >>> url=https%3A%2F%2Freviews.freebsd.org%2FD54923&data=05%7C02%7Cmichael.osipov%40innomotics.com%7C599792c98cac445815a108de5f529e81%7C698c6ffb74e34a84be68f22d8d3201a3%7C0%7C0%7C639053005625994409%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=fqqWtXQep%2FyB%2BinUOiod%2FO%2BqDOOQ4UC5O4KzvM36C7Q%3D&reserved=0 >>> --- >>>   release/tools/azure.conf     | 2 +- >>>   release/tools/openstack.conf | 2 +- >>>   stand/efi/loader/main.c      | 4 ++-- >>>   stand/i386/loader/main.c     | 4 ++-- >>>   4 files changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/release/tools/azure.conf b/release/tools/azure.conf >>> index 981e40566a1c..4fa6ba4d924d 100644 >>> --- a/release/tools/azure.conf >>> +++ b/release/tools/azure.conf >>> @@ -59,7 +59,7 @@ autoboot_delay="-1" >>>   beastie_disable="YES" >>>   loader_logo="none" >>>   hw.memtest.tests="0" >>> -console="comconsole efi vidconsole" >>> +console="comconsole,efi,vidconsole" >>>   comconsole_speed="115200" >>>   boot_multicons="YES" >>>   boot_serial="YES" >>> diff --git a/release/tools/openstack.conf b/release/tools/openstack.conf >>> index 9ce65a75c3c5..6cfb02bab9af 100644 >>> --- a/release/tools/openstack.conf >>> +++ b/release/tools/openstack.conf >>> @@ -33,7 +33,7 @@ vm_extra_pre_umount() { >>>       echo 'autoboot_delay="-1"' >> ${DESTDIR}/boot/loader.conf >>>       echo 'beastie_disable="YES"' >> ${DESTDIR}/boot/loader.conf >>>       echo 'boot_multicons="YES"' >> ${DESTDIR}/boot/loader.conf >>> -    echo 'console="comconsole vidconsole"' >> ${DESTDIR}/boot/ >>> loader.conf >>> +    echo 'console="comconsole,vidconsole"' >> ${DESTDIR}/boot/ >>> loader.conf >>>       echo 'comconsole_speed="115200"' >> ${DESTDIR}/boot/loader.conf >>>         # Reboot quickly, Don't wait at the panic screen >>> diff --git a/stand/efi/loader/main.c b/stand/efi/loader/main.c >>> index 22dbd10a0f37..7ff2cf188509 100644 >>> --- a/stand/efi/loader/main.c >>> +++ b/stand/efi/loader/main.c >>> @@ -1316,10 +1316,10 @@ main(int argc, CHAR16 *argv[]) >>>                   setenv("console", "comconsole", 1); >>>                   break; >>>               case VID_SER_BOTH: >>> -                setenv("console", "efi comconsole", 1); >>> +                setenv("console", "efi,comconsole", 1); >>>                   break; >>>               case SER_VID_BOTH: >>> -                setenv("console", "comconsole efi", 1); >>> +                setenv("console", "comconsole,efi", 1); >>>                   break; >>>                   /* case VIDEO_ONLY can't happen -- it's the first >>> if above */ >>>               } >> >> [Note: I CC'd Warner just because I'm not sure anyone else knows for >> sure about this area's complicated history and issues.] >> >> >> This looks possibly wrong to me for efi for all but amd64 --but for the >> references to comconsole, not the space vs. comma issue. >> >> >> stand: efi create eficom console device. >> (2023-05-11) >> >> QUOTE of > url=https%3A%2F%2Fcgit.freebsd.org%2Fsrc%2Fcommit%2Fstand%2Fefi%3Fid%3D2f131435bc22&data=05%7C02%7Cmichael.osipov%40innomotics.com%7C599792c98cac445815a108de5f529e81%7C698c6ffb74e34a84be68f22d8d3201a3%7C0%7C0%7C639053005626005673%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=b7UCUYk%2BJZ4wfJpjvdpv3zW7Vjuep0reJkcNgpl%2B3Gk%3D&reserved=0> >> console=comconsole talks to the hardware directly. This is available >> only on amd64. It is not available anywhere else (and so requires >> changes for people doing comconsole on aarch64) >> >> console=eficom talks to the console via EFI protocols.  It's available >> on amd64, aarch64 and riscv64. It's the first port that we find, though >> it can be overriden by efi_com_port (which should be set to the UID of >> the serial port, not the I/O port, despite the name). devinfo -v >> will give the UID to uartX mapping. >> >> This is an incompatible change for HYPER-V on amd64. It only works with >> eficom console, so you'll need to change your configuration in >> loader.conf. No compatibility hack will ever be provided for this (since >> it requires renamig, which the loader cannot reliably do). >> >> It's also an incompatible change for aarch64. comconsole will need to >> change to eficom. There might be a comconsole "shim" for this. >> END QUOTE >> >> >> stand: add comconsole backwards compatibility shim for aarch64 >> (2023-05-11) >> >> QUOTE of > url=https%3A%2F%2Fcgit.freebsd.org%2Fsrc%2Fcommit%2Fstand%2Fefi%3Fid%3Df93416d67743&data=05%7C02%7Cmichael.osipov%40innomotics.com%7C599792c98cac445815a108de5f529e81%7C698c6ffb74e34a84be68f22d8d3201a3%7C0%7C0%7C639053005626016462%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=%2BcXcfrBSDtWBYluSYlONTo%2FzYP761LUbk5mfxjQ3Brg%3D&reserved=0> >> Add a compat shim for the "comconsole" name so that people with a >> "console=comconsole" in their loader.conf on aarch64 will continue to >> work (though with a warning). >> >> This is only aarch64: it will never be there for amd64 (where comconsole >> always means talk to the hardware directly). To do that is too hard. >> END QUOTE >> >> >> But that last (f93416d67743) is only for: >> >> +#if defined(__aarch64__) && __FreeBSD_version < 1500000 >> +/* Hack for backward compatibility -- but only for a while */ >> +extern struct console comconsole; >> +#endif >> . . . >> +#if defined(__aarch64__) && __FreeBSD_version < 1500000 >> +    &comconsole, >> +#endif >> . . . (and so on) . . . >> >> So, as of FreeBSD 15+, aarch64 does not have comconsole as far as I can >> tell. >> >> >> It looks to me like for FreeBSD 15+ eficom should be referenced mostly, >> instead of comconsole, comconsole being only for amd64. >> >> For FreeBSD 14.3+ and stable/14 it may be that comconsole should be used >> for amd64 and aarch64. (stable/13 does not have the commits at all.) >> >> >> There is also a prior: >> >>         if (efi_has_gop()) >>             how |= RB_MULTIPLE; >>         else >>             how |= RB_MULTIPLE | RB_SERIAL; >>         setenv("console", "efi,comconsole", 1); >> >> and: >> >> #if defined(__riscv) >>     /* >>      * This workaround likely is papering over a real issue >>      */ >>     if ((uhowto & RB_SERIAL) != 0) >>         setenv("console", "comconsole", 1); >> #endif >> >> that may well both be wrong for stand/efi/loader/main.c too. > > Hi Mark, > > thanks for raising. I do not fully understand the point you are trying > to make. This change is a spinoff from https://reviews.freebsd.org/ > D54843 where we identified that comma is the preferred separator, but > space is allowed as well. For consistency reasons I have updated > everything to comma. I didn't change the actual values. > > Can you clarify? > > Michael > > Sounds like you were not the right person to reference for this and you might not be involved if anything does happen related to my notes/questions. Also: not tied to what you report for the context for your change. I was just prompted to think of the issue by the text presented in the commit. I had not been tracking the prior stages of your activity. I expect that my basic questions about the use of comconsole in stand/efi/loader/main.c are still appropriate, even if you would not be involved in answering them. I think I'll try to move this to freebsd-stable@ since it is off topic to your purpose in your commit. Future replies could omit: dev-commits-src-main@ -- === Mark Millard marklmi at yahoo.com